[GitHub] storm issue #2319: [STORM-2693] Nimbus assignments promotion

2017-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2319 Also given that the change is significant, we may want to integrate only 2.0.0 instead of having this in 1.x version line. ---

[GitHub] storm issue #2319: [STORM-2693] Nimbus assignments promotion

2017-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2319 @danny0405 To be clear, all the pull requests should be merged into master first, and merged back to 1.x version line. So to integrate your great effort into Apache Storm, we need PR

Re: [Discuss] Release Storm 1.2.0

2017-11-15 Thread Stig Rohde Døssing
+1 for starting release for both versions. 2017-11-16 0:24 GMT+01:00 Jungtaek Lim : > I think we could start release phase for both 1.1.2 and 1.2.0 when > https://github.com/apache/storm/pull/2423 will be merged. > > Thanks, > Jungtaek Lim (HeartSaVioR) > > 2017년 11월 16일 (목)

[GitHub] storm pull request #2423: STORM-2546: Fix storm-kafka-client spout stuck due...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2423 ---

[GitHub] storm issue #2421: [STORM-2815] UI HTTP server should return 403 if the user...

2017-11-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2421 @Ethanlm Thanks I merged this into master. Please let me know when you craft another PR for 1.x. Thanks in advance. ---

[GitHub] storm pull request #2420: [STORM-2814] Logviewer HTTP server should return 4...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2420 ---

Re: [Discuss] Release Storm 1.2.0

2017-11-15 Thread Jungtaek Lim
I think we could start release phase for both 1.1.2 and 1.2.0 when https://github.com/apache/storm/pull/2423 will be merged. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 11월 16일 (목) 오전 7:00, Alexandre Vermeerbergen 님이 작성: > Hello, > > I'd love to see a Storm 1.2.0

[GitHub] storm pull request #2422: [STORM-2814] Logviewer HTTP server should return 4...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2422 ---

[GitHub] storm pull request #2421: [STORM-2815] UI HTTP server should return 403 if t...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2421 ---

[GitHub] storm issue #2409: STORM-2796: Flux: Provide means for invoking static facto...

2017-11-15 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2409 @HeartSaVioR Thanks for the review. Addressed your comment and fixed another issue discovered in testing. ---

[GitHub] storm pull request #2424: [STORM-2820] fix validateTopologyWorkerMaxHeapSize...

2017-11-15 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2424 [STORM-2820] fix validateTopologyWorkerMaxHeapSizeConfigs function never picks up the value set by nimbus problem As stated in https://issues.apache.org/jira/browse/STORM-2820, the

Re: [Discuss] Release Storm 1.2.0

2017-11-15 Thread Stig Rohde Døssing
I think releasing once STORM-2546 goes in sounds good. 2017-11-15 7:29 GMT+01:00 Arun Mahadevan : > Hi, > > Looks like we are only waiting on https://issues.apache.org/ > jira/browse/STORM-2546 . > > Are there any other issues which are blockers for Storm 1.2.0? Would be >

[GitHub] storm issue #2300: STORM-2691: Make storm-kafka-client implement the Trident...

2017-11-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2300 Rebased to fix conflicts. ---

[GitHub] storm pull request #2423: STORM-2546: Fix storm-kafka-client spout stuck due...

2017-11-15 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2423 STORM-2546: Fix storm-kafka-client spout stuck due to topic compaction (1.x) 1.x version of https://github.com/apache/storm/pull/2307. All changes are in the last commit, will squash when

[GitHub] storm issue #2422: [STORM-2814] Logviewer HTTP server should return 403 if t...

2017-11-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2422 It seems that this patch should be able to merge into 1.1.x-branch easily. If there is a merge issue, I would like to file a separate pull request for it. ---

[GitHub] storm issue #2420: [STORM-2814] Logviewer HTTP server should return 403 inst...

2017-11-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2420 Last commit changed other place from using 401 to 403 so that we can have a consistent http code for AuthorizedExceptions. ---

[GitHub] storm pull request #2422: [STORM-2814] Logviewer HTTP server should return 4...

2017-11-15 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2422 [STORM-2814] Logviewer HTTP server should return 403 if the user is unauthorized Similar to https://github.com/apache/storm/pull/2420 . This is for 1.x-branch. You can merge this pull request