Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151632384
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -129,23 +130,34 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151630914
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -562,43 +560,54 @@ private void initCommon(String id, IComponent
component
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151636460
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -187,16 +199,21 @@
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151697329
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/topology/MasterBatchCoordinator.java
---
@@ -308,7 +308,7 @@ public String toString() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151697850
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java ---
@@ -562,43 +560,54 @@ private void initCommon(String id, IComponent
compon
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151699527
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -129,23 +130,34
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151699779
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/topology/MasterBatchCoordinator.java
---
@@ -308,7 +308,7 @@ public String toString() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151700529
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -187,16 +199,21
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151704811
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -129,23 +130,34 @@
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r151707538
--- Diff:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestGenericResourceAwareStrategy.java
---
@@ -187,16 +199,21 @@
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo I have fixed the issues you called out
@Ethanlm I fixed the issue you saw.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2419
Thanks, +1
---
I am also in agreement that we should not delay the 1.2.0 release for too long,
but in order to release it a few things need to be kept in mind:
- If we want to avoid releasing 1.3.0 soon or at all, that means that we
should include in 1.2.0 as many important features (e.g. metricsV2) as possib
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo thanks for the review you found a lot of bugs and made this a lot
better.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2419
Thanks, happy to help :)
---
My concern isn't really whether we keep backporting features to 1.x for now
or not. I would like to see an initial release in the 2.x line soon,
because master and 1.x have diverged by a good bit. I think it's to
everyone's benefit if we can reduce how much work goes into backporting
features. Once
Hello Hugo,
As I already posted, I was getting ready to test the upcoming RC, so yeah :
as soon as I have some binaries for testing, I can run any Storm 1.2.0
preview on my pre-production (well stressed) environment. Is there some URL
from where I can download such "snapshot" binaries?
Best reg
Alexandre,
https://www.dropbox.com/s/mg2gnunk24oesyc/apache-storm-1.2.0-SNAPSHOT.tar.gz?dl=0
Above link is custom binary distribution of current 1.x-branch (SNAPSHOT of
1.2.0). Could you run the test in your environment first and let us know
about the result? Regardless of including metrics V2 to
18 matches
Mail list logo
