Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717836
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1672,7 +1703,7 @@ private int fragmentedCpu() {
long b
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717747
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -231,7 +183,15 @@
@VisibleForTesting
public
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717599
--- Diff: storm-server/pom.xml ---
@@ -130,7 +130,7 @@
maven-checkstyle-plugin
-
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717501
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -792,15 +795,18 @@
(bind _ (log-message "ass1, t76, pre beat: " (pr-str ass
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717439
--- Diff:
storm-client/test/jvm/org/apache/storm/assignments/LocalAssignmentsBackendTest.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717373
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152717096
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1547,26 +1533,21 @@ public static ComponentPageInfo aggCompExecsStats(
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152716882
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -291,7 +291,10 @@ private Scope calculateScope(Map
taskToNod
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152716688
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -51,12 +51,7 @@
import org.apache.storm.task.WorkerTopologyConte
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152716651
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -382,6 +374,33 @@ public void establishLogSettingCallback() {
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152716491
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -43,13 +44,15 @@
private static Logger LOG =
LoggerFact
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152716336
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java
---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache So
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2433
Please fix the checkstyle issue on `storm-client` or "temporary" change max
violation count so that Travis CI can build the code properly. Please also note
that max violation count for all of mod
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152705847
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -520,7 +522,7 @@
(is (= 10 (count (task-info "4"
(is (= 7
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r15270
--- Diff:
storm-client/test/jvm/org/apache/storm/assignments/LocalAssignmentsBackendTest.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apach
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152695062
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/LocalAssignmentsBackendFactory.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Ap
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152698386
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -147,21 +153,52 @@ protected void
issueMapCallback(ConcurrentH
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703334
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -51,12 +51,7 @@
import org.apache.storm.task.WorkerTopologyCon
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152693807
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java
---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152706237
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -48,35 +48,9 @@
import org.apache.storm.daemon.supervisor.StandaloneSu
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703257
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -382,6 +374,33 @@ public void establishLogSettingCallback() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703971
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1255,11 +1227,11 @@ public static ComponentPageInfo aggCompExecsStats(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152694460
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java
---
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152706092
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -792,15 +795,18 @@
(bind _ (log-message "ass1, t76, pre beat: " (pr-str a
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152704498
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152705675
--- Diff:
storm-client/test/jvm/org/apache/storm/assignments/LocalAssignmentsBackendTest.java
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apach
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152706208
--- Diff: storm-server/pom.xml ---
@@ -130,7 +130,7 @@
maven-checkstyle-plugin
-
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703902
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -21,43 +21,15 @@
import org.apache.storm.cluster.ExecutorBeat;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152705026
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1589,18 +1570,16 @@ public static ComponentPageInfo aggCompExecsStats(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702580
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -382,6 +374,33 @@ public void establishLogSettingCallback() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702351
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -50,25 +51,14 @@
import org.apache.storm.executor.ExecutorShutdown;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152705852
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -454,7 +456,7 @@
(is (= 2 (storm-num-workers state "mystorm"))) ;; becaus
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152706078
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -792,15 +795,18 @@
(bind _ (log-message "ass1, t76, pre beat: " (pr-str a
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152704189
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1547,26 +1533,21 @@ public static ComponentPageInfo aggCompExecsStats(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702341
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -50,25 +51,14 @@
import org.apache.storm.executor.ExecutorShutdown;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152698394
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -147,21 +153,52 @@ protected void
issueMapCallback(ConcurrentH
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702114
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java
---
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152706310
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -71,69 +75,17 @@
import org.apache.storm.daemon.DaemonCommon;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152696040
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -43,13 +44,15 @@
private static Logger LOG =
LoggerFa
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702076
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/InMemoryAssignmentBackend.java
---
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152698363
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -147,21 +153,52 @@ protected void
issueMapCallback(ConcurrentH
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152708312
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1733,13 +1825,24 @@ private TopologyResources
getResourcesForTop
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152704003
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1360,11 +1329,11 @@ public static ComponentPageInfo aggCompExecsStats(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703031
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -382,6 +374,33 @@ public void establishLogSettingCallback() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152693678
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1293,6 +1318,44 @@
@isPositiveNumber
public static final String SUPE
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152701420
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -147,21 +153,52 @@ protected void
issueMapCallback(ConcurrentH
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703493
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -647,6 +625,22 @@ public static boolean isConnectionReady(IConnecti
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703836
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -291,7 +291,10 @@ private Scope calculateScope(Map
taskToN
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152702042
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java
---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152701486
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -243,6 +280,25 @@ public StormBase stormBase(String stormId, Ru
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152707672
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1395,10 +1374,59 @@ private void updateAllHeartbeats(Map existing
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152703886
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -21,43 +21,15 @@
import org.apache.storm.cluster.ExecutorBeat;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152693895
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java
---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152552216
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -991,6 +991,31 @@
@isPositiveNumber
public static final String NIMBUS
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2433#discussion_r152693735
--- Diff:
storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java
---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2432
@srdo @HeartSaVioR Thanks for the review
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2432
I think we can avoid this issue in the future by upgrading Jackson
https://github.com/FasterXML/jackson-databind/issues/373. The fix should be
included as of version 2.7, which is when JDK7 basic classe
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2432
+1
My bad, the change to Path was made in
https://github.com/apache/storm/pull/2360. @lawrencecraft you might want to be
aware of this if you're still working on backporting logviewer changes t
Hello All,
I seems that the "[Discuss] Release Storm 1.2.0" thread reached some limits
as my latest posts on it aren't being received.
Whatever, here's the follow-up of my tests with storm-1.2.0 preview with
latest version of Stig's storm-kafka-client:
It works !
But... to make my topologies co
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2319
@HeartSaVioR @revans2 i have moved all the features to
https://github.com/apache/storm/pull/2389 for 1.1.x-branch
https://github.com/apache/storm/pull/2433 for 2.0-branch
so this is close
Github user danny0405 closed the pull request at:
https://github.com/apache/storm/pull/2319
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2433
@danny0405
Thanks for updating your great effort!
The change is huge, and unfortunately I can't find time to review this at
once. I'll try to review partially and multiple times.
---
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2433
[STORM-2693] Heartbeats and assignments promotion for storm2.0
For large cluster support, good scheduling performance for scheduling and
assignments distribution.
For nimbus heartbeats pr
Github user danny0405 closed the pull request at:
https://github.com/apache/storm/pull/2431
---
64 matches
Mail list logo
