Re: [Discuss] Release Storm 1.2.0 (cont.)

2017-12-27 Thread Jungtaek Lim
Looks like we got lost the chance to make release phase be started in 2017, but I think we are really close to be sure we could start the process in early Jan. 2018. We haven't had "feature freeze" before releasing, so typically we still have a chance to get more features in Storm 1.2.0. So far,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

2017-12-27 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r158908261 --- Diff: examples/storm-perf/pom.xml --- @@ -81,7 +81,7 @@ maven-checkstyle-plugin -

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

2017-12-27 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r158906210 --- Diff: docs/Performance.md --- @@ -0,0 +1,128 @@ +--- +title: Performance Tuning +layout: documentation +documentation: true +---

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

2017-12-27 Thread roshannaik
Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r158906063 --- Diff: conf/defaults.yaml --- @@ -253,11 +278,17 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

Re: [DISCUSS] Release Storm 1.0.5 / 1.1.2

2017-12-27 Thread Jungtaek Lim
I have been really busy so couldn't care about releases, and now I got some time period to track again. We have been delaying new release, since we have been focusing on 1.2.0 and issues relevant in storm-kafka-client have been raised continuously. (though things looks like going to be less critic

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-27 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r158899660 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java --- @@ -26,6 +26,7 @@ import java.util.List; pu

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2017-12-27 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2480#discussion_r158899496 --- Diff: pom.xml --- @@ -278,7 +278,7 @@ kafka_2.10 -0.10.0.0 +0.11.0.2 --- End diff --

[NOTICE] Sorted out versions in Apache JIRA

2017-12-27 Thread Jungtaek Lim
Hi devs, Just FYI, I have sorted out versions in Apache JIRA - marked all versions which are already released as released with actual release date. I also remove fix version in some issues which are open but version is already released. Thanks, Jungtaek Lim (HeartSaVioR)

[GitHub] storm pull request #2483: (1.x) STORM-2870 Properly shutdown ExecutorService...

2017-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2483 ---

[GitHub] storm pull request #2482: STORM-2870 Properly shutdown ExecutorService in Fi...

2017-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2482 ---

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2017-12-27 Thread omkreddy
Github user omkreddy commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r158812503 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java --- @@ -26,6 +26,7 @@ import java.util.List; publi

[GitHub] storm pull request #2481: STORM-2869: Only discard outdated records when adj...

2017-12-27 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2481#discussion_r158788258 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java --- @@ -1,379 +0,0 @@ -/* - * Licensed

[GitHub] storm pull request #2481: STORM-2869: Only discard outdated records when adj...

2017-12-27 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2481#discussion_r158784650 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java --- @@ -1,379 +0,0 @@ -/* - * Lice