[GitHub] storm issue #2595: set '* text=auto' in .gitattributes in order to avoid mer...

2018-03-22 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/2595 [`*.png binary` seems to cause tests to fail because of unavailable test resources](https://travis-ci.org/krichter722/storm/builds/356601827?utm_source=email&utm_medium=notification). Omit it and

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

2018-03-22 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @revans2 Hi, is threre anything i can do now for this patch? ---

[GitHub] storm issue #600: STORM-903: fix java.lang.ClassNotFoundException with org.a...

2018-03-22 Thread d2r
Github user d2r commented on the issue: https://github.com/apache/storm/pull/600 @revans2, @harshach , @tedxia This pull request is stale, and it looks as if we are pulling in commons-codec [explicitly](https://github.com/apache/storm/blob/0fdad2c0ff357c431454128dd937edf2876

[GitHub] storm pull request #2595: set '* text=auto' in .gitattributes in order to av...

2018-03-22 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2595#discussion_r176485833 --- Diff: .gitattributes --- @@ -1,2 +1,9 @@ # Some storm-webapp logviewer tests require input files to have LF line endings due to byte counting. -sto

[GitHub] storm pull request #2595: set '* text=auto' in .gitattributes in order to av...

2018-03-22 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2595#discussion_r176485726 --- Diff: .gitattributes --- @@ -1,2 +1,9 @@ # Some storm-webapp logviewer tests require input files to have LF line endings due to byte counting. -sto

[GitHub] storm pull request #2595: set '* text=auto' in .gitattributes in order to av...

2018-03-22 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2595#discussion_r176485883 --- Diff: .gitattributes --- @@ -1,2 +1,9 @@ # Some storm-webapp logviewer tests require input files to have LF line endings due to byte counting. -sto

[GitHub] storm pull request #2603: [STORM-3003] Adding Assignment caching to Nimbus

2018-03-22 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2603 [STORM-3003] Adding Assignment caching to Nimbus Since nimbus ( scheduler generates assignments) it can cache it instead of polling for it from ZK or other state manager. This would improve sch

[GitHub] storm issue #2595: set '* text=auto' in .gitattributes in order to avoid mer...

2018-03-22 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/2595 [Adding `*.[extension] binary` seems to cause the tests to fail regardless of the order](https://travis-ci.org/krichter722/storm/jobs/357184158). The question is why. Maybe asking a question on s

[GitHub] storm issue #2595: set '* text=auto' in .gitattributes in order to avoid mer...

2018-03-22 Thread krichter722
Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/2595 Forget that. The last `git rm --cached -r . && git add .` deleted (!) the binary files which the test tries to load. I didn't pay attention, my bad. ---