Re: New Committer/PMC Member: Roshan Naik

2018-04-05 Thread Erik Weathers
Congrats Roshan!! On Thu, Apr 5, 2018 at 8:26 PM Ethan Li wrote: > Congratulations! Roshan > > Ethan Li > > > On Apr 5, 2018, at 21:40, Jungtaek Lim wrote: > > > > Congrats Roshan! > > > > 2018년 4월 6일 (금) 오전 11:39, P. Taylor Goetz

Re: New Committer/PMC Member: Roshan Naik

2018-04-05 Thread Ethan Li
Congratulations! Roshan Ethan Li > On Apr 5, 2018, at 21:40, Jungtaek Lim wrote: > > Congrats Roshan! > > 2018년 4월 6일 (금) 오전 11:39, P. Taylor Goetz 님이 작성: > >> Please join me in congratulating and welcoming Roshan Naik as the latest >> Apache Storm

Re: New Committer/PMC Member: Roshan Naik

2018-04-05 Thread Jungtaek Lim
Congrats Roshan! 2018년 4월 6일 (금) 오전 11:39, P. Taylor Goetz 님이 작성: > Please join me in congratulating and welcoming Roshan Naik as the latest > Apache Storm committer and PMC member. > > Welcome Roshan! > > -Taylor > >

New Committer/PMC Member: Roshan Naik

2018-04-05 Thread P. Taylor Goetz
Please join me in congratulating and welcoming Roshan Naik as the latest Apache Storm committer and PMC member. Welcome Roshan! -Taylor

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

2018-04-05 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2618 I am inclined to choose option 3 because: 1. We now have already made an RPC request for killing/starting-worker from master to supervisors as soon as we the event happens on master. So the

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179570567 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179568920 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179569824 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179570190 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179569508 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179571966 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2623#discussion_r179569132 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java --- @@ -477,45 +414,136 @@

[GitHub] storm pull request #2623: [STORM-2687] Group Topology executors by network p...

2018-04-05 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2623 [STORM-2687] Group Topology executors by network proximity needs and schedule them on network wise close slots https://issues.apache.org/jira/browse/STORM-2687 This tries to schedule

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

2018-04-05 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2618 OK good I do understand the problem. There really are a few ways that I see we can make the stack trace much less likely to come out in the common case. The following are in my preferred

[GitHub] storm issue #2622: STORM-3020: fix possible race condition in AsyncLocalizer

2018-04-05 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2622 Thanks for the review @danny0405 This was not trying to fix STORM-2905. This was a separate race condition I found when reviewing your pull request for STORM-2905. ---

[GitHub] storm pull request #2614: [STORM-2983] fix the issue that the inter-worker t...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2614 ---

[GitHub] storm issue #2622: STORM-3020: fix possible race condition in AsyncLocalizer

2018-04-05 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2622 I test it, and it worked ok as before, but a KeyNotFoundException still got of master when finally cleaned the base blobs. ---

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

2018-04-05 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2618 @danny0405 I agree with you that the race condition is between nimbus deleting the blobs and the supervisor fully processing the topology being killed. But i still think we should