[GitHub] storm pull request #2627: STORM-3022 Decouple storm-hive UTs with Hive

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2627 STORM-3022 Decouple storm-hive UTs with Hive * mock/extend any needed classes to avoid interacting with Hive itself This patch is for 1.x-branch. Patch for master branch is here: #2626

[GitHub] storm pull request #2626: STORM-3022 Decouple storm-hive UTs with Hive

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2626 STORM-3022 Decouple storm-hive UTs with Hive * mock/extend any needed classes to avoid interacting with Hive itself You can merge this pull request into a Git repository by running: $ git

[GitHub] storm pull request #2518: STORM-2902: Some improvements for storm-rocketmq m...

Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2518#discussion_r180281409 --- Diff: external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/spout/RocketMqSpout.java --- @@ -60,14 +58,14 @@ public class RocketMqSpout

[GitHub] storm issue #2622: STORM-3020: fix possible race condition in AsyncLocalizer

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2622 @HeartSaVioR thanks for the review. I fixed your concerns by making them all ConcurrentHashMaps and adding a note about why they need to be that. I could not find a good way to remove the

[GitHub] storm pull request #2616: STORM-3005-1.0.x-removed-deprecation-LinearDRPCTop...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2616 ---

[GitHub] storm pull request #2617: STORM-3005-1.1.x-removed-deprecation-LinearDRPCTop...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2617 ---

[GitHub] storm pull request #2615: STORM-3005-removed-deprecation-LinearDRPCTopologyB...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2615 ---

[GitHub] storm issue #2624: STORM-2909 port new metrics to 2.x branch

Github user agresch commented on the issue: https://github.com/apache/storm/pull/2624 @HeartSaVioR made the changes you suggested. I can look at the documentation changes. ---

[GitHub] storm issue #601: STORM-917 : Ability to emit from the spout to a specific s...

Github user d2r commented on the issue: https://github.com/apache/storm/pull/601 > this was a quick fix i did for a POC under 30 mins, It might not be the right way to go about this. @anishek This pull request has gone stale. Do we want to continue with this proposed change

[GitHub] storm issue #2624: STORM-2909 port new metrics to 2.x branch

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2624 Could you take up copying documentation from another PR as well, based on #2526? ---

[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2624#discussion_r180053408 --- Diff: storm-server/src/main/java/org/apache/storm/nimbus/DefaultTopologyValidator.java --- @@ -15,19 +15,53 @@ * See the License for the

[GitHub] storm pull request #2624: STORM-2909 port new metrics to 2.x branch

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2624#discussion_r180049067 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -223,7 +224,7 @@ private Object loadWorker(Map