GitHub user cleroux opened a pull request:
https://github.com/apache/storm/pull/2649
[STORM-3043] Fix NullPointerException when apply() returns null
A null List is a valid return value from RecordTranslator.apply() if the
ConsumerRecord is invalid.
You can merge this pull request
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2638
@kishorvpatil Can you elaborate a bit? I don't understand why
`TimeoutException` would be wrapped in an `InterruptedException`? Where is the
log line you posted coming from, a grep of Storm didn't turn
Github user agresch closed the pull request at:
https://github.com/apache/storm/pull/2645
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2648
STORM-3013: Keep KafkaConsumer open when storm-kafka-client spout is â¦
â¦deactivated, in order to keep metrics working
See https://issues.apache.org/jira/browse/STORM-3013
The
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2642
+1, thanks @cleroux, merged to master. Please open another PR against
1.x-branch, so this fix can make it into 1.x releases too :)
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2642
---
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
@ghajos We can bind to the port then close the port and then bind to the
same port again. We have unit tests that can be used as a starting point.
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@raghavgautam I think it is out of scope to test a tcp testing in Storm. Do
you have an idea how to do that?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184707886
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java ---
@@ -101,6 +101,7 @@
private final AtomicBoolean
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184711553
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
---
@@ -153,6 +153,35 @@ public void testSimpleText_ACK() throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2633#discussion_r184710659
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
---
@@ -153,6 +153,35 @@ public void testSimpleText_ACK() throws
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2635
rebased
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2634
rebased.
---
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
Can you please add a test for this ?
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2636
@cfriaszapater
Thanks for the contribution. Basically we receive PRs which go first to the
master branch, and additional PRs (against 1.x-branch) which is expected to not
cleanly ported
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2646
@HeartSaVioR Thanks very much!
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2646
@Ethanlm
You can refer the DEVELOPER doc which guides contributors as well as
committers.
https://github.com/apache/storm/blob/master/DEVELOPER.md#merge-a-pull-request-or-patch
You
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2646
@HeartSaVioR Sorry I forgot to change it. I don't see any merge button. Do
I need to do it in some other way
---
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2633
@srdo Can you please take a look at?
---
Github user cfriaszapater commented on the issue:
https://github.com/apache/storm/pull/2636
Ah, that's strange, because I did not change anything out of
external/storm-cassandra. So that should be failing before this pull request.
Anyway, I'll try what you say, thanks.
---
20 matches
Mail list logo
