[GitHub] storm issue #2637: Map of Spout configurations from `storm-kafka` to `storm-...

2018-04-30 Thread srishtyagrawal
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @srdo can you merge this if it looks ok? ---

Performance comparison between storm-kafka & storm-kafka-client

2018-04-30 Thread Srishty Agrawal
Do we know of any performance implications when a topology using storm-kafka consumes Kafka messages with 0.8 format versus a topology using storm-kafka-client? Thanks, Srishty Agrawal

[GitHub] storm issue #2637: Map of Spout configurations from `storm-kafka` to `storm-...

2018-04-30 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2637 @erikdw I am reviewing this now. Sorry but I was away the last few days. ---

[GitHub] storm issue #2638: [STORM-3034] Adding exception stacktrace for executor fai...

2018-04-30 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2638 @srdo , What I mean is there are many instances where kafka is wrapping actual exceptions into `InterruptedException`. I am not sure why/what is the objective, but only way to understand the sou

[GitHub] storm pull request #2651: [STORM-3054] Add Topology level configuration sock...

2018-04-30 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2651 [STORM-3054] Add Topology level configuration socket timeout for DRPC Invocation Client This patch fixes following this: - Add Topology level configuration socket timeout for DRPC Invo

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185163739 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185168807 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185161496 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185168952 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185168669 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185167619 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185160807 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185168182 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185174192 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185174341 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```

[GitHub] storm pull request #2637: Map of Spout configurations from `storm-kafka` to ...

2018-04-30 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2637#discussion_r185174572 --- Diff: docs/storm-kafka-client.md --- @@ -313,4 +313,37 @@ KafkaSpoutConfig kafkaConf = KafkaSpoutConfig .setTupleTrackingEnforced(true) ```