[GitHub] storm pull request #2659: STORM-3042 restore topology.acker.cpu.pcore.percen...

2018-05-03 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2659#discussion_r185929379 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java --- @@ -293,7 +295,7 @@ public Double

[GitHub] storm pull request #2659: STORM-3042 restore topology.acker.cpu.pcore.percen...

2018-05-03 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2659#discussion_r185929506 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -533,11 +533,11 @@ private static StormBase make(TopologyStatus

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-03 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @HeartSaVioR @ghajos Please review. ---

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2643 @HeartSaVioR Please look at this pull request https://github.com/apache/storm/pull/2660 ---

[GitHub] storm pull request #2660: STORM-3056: Add a test for quickly rebinding to a ...

2018-05-03 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/2660 STORM-3056: Add a test for quickly rebinding to a port Adding test as per discussion on https://github.com/apache/storm/pull/2643#issuecomment-385003933 You can merge this pull request into a

[GitHub] storm pull request #2659: STORM-3042 restore topology.acker.cpu.pcore.percen...

2018-05-03 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2659 STORM-3042 restore topology.acker.cpu.pcore.percent TOPOLOGY_ACKER_CPU_PCORE_PERCENT and other similar settings in adjustResourcesForExec() were orphaned accidentally by a previous pull request.

[VOTE] Release Apache Storm 1.1.3 (rc1)

2018-05-03 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.1.3 (rc1) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.1.3-rc1/RELEASE_NOTES.html The tag/commit to be voted upon is v1.1.3:

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

2018-05-03 Thread P. Taylor Goetz
CORRECTION: The Nexus staging repository for this rc is: https://repository.apache.org/content/repositories/orgapachestorm-1064 > On May 3, 2018, at 11:42 AM, P. Taylor Goetz wrote: > > This is a call

Re: [VOTE] Release Apache Storm 1.2.2(rc1)

2018-05-03 Thread Alexandre Vermeerbergen
Thank you very much, this is awesome! Alexandre Vermeerberen 2018-05-03 16:36 GMT+02:00 P. Taylor Goetz : > Yes, I will cancel the vote and spin up a new rc. > > -Taylor > >> On May 3, 2018, at 9:51 AM, Alexandre Vermeerbergen >> wrote: >> >> Hello,

[CANCELED] [VOTE] Release Apache Storm 1.2.2(rc1)

2018-05-03 Thread P. Taylor Goetz
Canceling in order to include the fix for STORM-3309 in this release. -Taylor > On May 2, 2018, at 4:29 PM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.2 (rc1) > > Full list of changes in this release: > >

Re: [VOTE] Release Apache Storm 1.2.2(rc1)

2018-05-03 Thread P. Taylor Goetz
Yes, I will cancel the vote and spin up a new rc. -Taylor > On May 3, 2018, at 9:51 AM, Alexandre Vermeerbergen > wrote: > > Hello, > > Would it be possible to include > https://issues.apache.org/jira/browse/STORM-3039 in Storm 1.2.2 ? > > Best regards, > Alexandre

[GitHub] storm pull request #2658: Storm 2171: Removing LocalFsBlobStore specific Nim...

2018-05-03 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2658 Storm 2171: Removing LocalFsBlobStore specific Nimbus actions You can merge this pull request into a Git repository by running: $ git pull https://github.com/govind-menon/storm

Re: [VOTE] Release Apache Storm 1.2.2(rc1)

2018-05-03 Thread Alexandre Vermeerbergen
Hello, Would it be possible to include https://issues.apache.org/jira/browse/STORM-3039 in Storm 1.2.2 ? Best regards, Alexandre Vermeerbergen 2018-05-02 22:29 GMT+02:00 P. Taylor Goetz : > This is a call to vote on releasing Apache Storm 1.2.2 (rc1) > > Full list of changes

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread ghajos
Github user ghajos commented on the issue: https://github.com/apache/storm/pull/2643 @HeartSaVioR @raghavgautam @arunmahadevan Thank you for the review! ---

[GitHub] storm pull request #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2643 ---

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2643 Anyway +1 again. ---

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2643 I don't feel it is mandatory to add a test since it is a known option. I'll merge this shortly since no one add new review comments so far. @raghavgautam Could you please submit a patch