[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190067973 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190059863 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-22 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2687 STORM-3061: thrift 0.11 This moves to thrift 0.11 The only files changed are pom.xml and genthrift.sh. The other files are all generated. You can merge this pull request into a Git

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

2018-05-22 Thread revans2
Github user revans2 closed the pull request at: https://github.com/apache/storm/pull/2675 ---

[GitHub] storm issue #2675: STORM-3061: Upgrade lots of dependencies

2018-05-22 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2675 I'll try to break it down to more manageable chunks that are split up by component as much as possible. There are a lot of the dependencies that cross boundaries though I will call those out in

[GitHub] storm pull request #2670: STORM-3068: STORM_JAR_JVM_OPTS are not passed to s...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2670 ---

[GitHub] storm pull request #2659: STORM-3042 restore topology.acker.cpu.pcore.percen...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2659 ---

[GitHub] storm pull request #2683: STORM-3077 Upgrade Disruptor version to 3.3.11 (1....

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2683 ---

[GitHub] storm pull request #2684: STORM-3079 add getMessage() support for thrift exc...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2684 ---

[GitHub] storm pull request #2651: [STORM-3054] Add Topology level configuration sock...

2018-05-22 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2651#discussion_r189821240 --- Diff: storm-client/src/jvm/org/apache/storm/drpc/ReturnResults.java --- @@ -103,21 +92,34 @@ public void execute(Tuple input) {