[GitHub] storm pull request #2691: STORM-3061: Update version of hbase

2018-05-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2691#discussion_r190432849 --- Diff: pom.xml --- @@ -294,7 +294,7 @@ 0.14.0 2.6.1 ${hadoop.version} -1.1.12 +1.4.4 ---

[GitHub] storm issue #2692: STORM-3083 Upgrade HikariCP version to 2.4.7

2018-05-23 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2692 +1 ---

[GitHub] storm pull request #2691: STORM-3061: Update version of hbase

2018-05-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2691#discussion_r190428653 --- Diff: pom.xml --- @@ -294,7 +294,7 @@ 0.14.0 2.6.1 ${hadoop.version} -1.1.12 +1.4.4 ---

[GitHub] storm pull request #2691: STORM-3061: Update version of hbase

2018-05-23 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2691#discussion_r190424484 --- Diff: pom.xml --- @@ -294,7 +294,7 @@ 0.14.0 2.6.1 ${hadoop.version} -1.1.12 +1.4.4

[GitHub] storm pull request #2692: STORM-3083 Upgrade HikariCP version to 2.4.7

2018-05-23 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2692 STORM-3083 Upgrade HikariCP version to 2.4.7 * Please refer https://issues.apache.org/jira/browse/STORM-3083 for more details This can be safely ported back to 1.x-branch as well. You

[GitHub] storm pull request #2691: STORM-3061: Update version of hbase

2018-05-23 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2691 STORM-3061: Update version of hbase This updates the version of hbase used and cleans up some of the dependencies. The biggest change besides updating the version is that we remove storm-s

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

2018-05-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2688#discussion_r190405202 --- Diff: bin/storm.py --- @@ -705,7 +705,6 @@ def nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"): cppaths = [CLUSTER_CONF_DIR]

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

2018-05-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2688#discussion_r190401760 --- Diff: bin/storm.py --- @@ -705,7 +705,6 @@ def nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"): cppaths = [CLUSTER_CONF_DIR] jvmo

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

2018-05-23 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2688#discussion_r190396554 --- Diff: bin/storm.py --- @@ -705,7 +705,6 @@ def nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"): cppaths = [CLUSTER_CONF_DIR]

Re: [VOTE] Release Apache Storm 1.2.2 (rc3)

2018-05-23 Thread Jungtaek Lim
REMINDER: The vote has been opened from 6 days ago, and still has only two binding +1s. Please verify the release candidate and vote. 2018년 5월 21일 (월) 오후 11:16, Julien Nioche 님이 작성: > +1 non binding > > compiled + ran StormCrawler topology without problems > > Thanks > > Julien > > > > On 17 May

Re: [VOTE] Release Apache Storm 1.1.3 (rc2)

2018-05-23 Thread Jungtaek Lim
REMINDER: The vote has been opened from 5 days ago, and still has only one binding +1s. Please verify the release candidate and vote. 2018년 5월 19일 (토) 오전 10:49, Jungtaek Lim 님이 작성: > This release candidate contains md5/sha for src archives, unlike 1.2.2 > RCs. May worth to check that. > > +1 (bin

[GitHub] storm pull request #2690: STORM-3061: Clean up some storm-druid dependencies

2018-05-23 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2690 STORM-3061: Clean up some storm-druid dependencies `mvn dependency:tree` showed that the only real dependency changes were for scala and jackson that went from 2.4.6 to 2.9.4. I am not tota

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2687 ---

[GitHub] storm issue #2687: STORM-3061: thrift 0.11

2018-05-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2687 Yes I reran the integration tests manually and they all passed. ---

[GitHub] storm issue #2687: STORM-3061: thrift 0.11

2018-05-23 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2687 The integration test failures look unrelated to this change. ---

[GitHub] storm issue #2687: STORM-3061: thrift 0.11

2018-05-23 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2687 +1 LGTM. ---

[GitHub] storm pull request #2689: STORM-3061: rocket, jms, and mqtt updates

2018-05-23 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2689 STORM-3061: rocket, jms, and mqtt updates This updates some dependencies for the jms examples, mqtt examples, rocketmq examples, and updates activemq implementation used for testing jms, rocketmq,

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190294254 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift --g

[GitHub] storm issue #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2687 +1 ---

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190287991 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

2018-05-23 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2688 STORM-3061: Remove unused core dependencies This is for disruptor and java.jmx You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190183265 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift --g

[GitHub] storm pull request #2687: STORM-3061: thrift 0.11

2018-05-23 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2687#discussion_r190175640 --- Diff: storm-client/src/genthrift.sh --- @@ -17,7 +17,7 @@ rm -rf gen-javabean gen-py py rm -rf jvm/org/apache/storm/generated -thrift --g