Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192434951
--- Diff: examples/storm-loadgen/pom.xml ---
@@ -67,6 +67,22 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xs
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192433936
--- Diff: DEVELOPER.md ---
@@ -239,8 +239,13 @@ To pull in a merge request you should generally follow
the command line instruct
# Build the code and
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2696
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2696
The examples are slightly adjusted versions of some code that appears in
the flux-core tests
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2697
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2697
Thanks for the review
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2699
STORM-3087: Make FluxBuilder.canInvokeWithArgs check whether the actuâ¦
â¦al argument type is assignable to Number before deciding that a method
with a primitive parameter can be invoked
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2686
Thanks @agresch, merged to master.
I forgot to check that commits were squashed, hopefully it doesn't bother
anyone too much.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2686
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2686
+1, thanks for addressing my nitpicks.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2695
---
11 matches
Mail list logo
