[GitHub] storm pull request #2685: STORM-1294: Port netty-unit-test to Java

2018-06-03 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2685#discussion_r192583770 --- Diff: storm-core/test/jvm/org/apache/storm/messaging/netty/NettyTest.java --- @@ -0,0 +1,382 @@ +/* + * Copyright 2018 The Apache Software Foundatio

[GitHub] storm pull request #2699: STORM-3087: Make FluxBuilder.canInvokeWithArgs che...

2018-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2699 ---

[GitHub] storm issue #2691: STORM-3061: Update version of hbase

2018-06-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2691 @revans2 Do you still plan to do manual tests on this patch? Sadly I couldn't do it myself for now, so would like to rely on your test result. ---

[GitHub] storm pull request #2685: STORM-1294: Port netty-unit-test to Java

2018-06-03 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2685#discussion_r192579594 --- Diff: storm-core/test/jvm/org/apache/storm/messaging/netty/NettyTest.java --- @@ -0,0 +1,382 @@ +/* + * Copyright 2018 The Apache Software Fo

[GitHub] storm pull request #2685: STORM-1294: Port netty-unit-test to Java

2018-06-03 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2685#discussion_r192579513 --- Diff: storm-core/test/jvm/org/apache/storm/messaging/netty/NettyTest.java --- @@ -0,0 +1,382 @@ +/* + * Copyright 2018 The Apache Software Fo