[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Ping. ---

[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.

Github user zd-project commented on a diff in the pull request: https://github.com/apache/storm/pull/2714#discussion_r195246920 --- Diff: storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java --- @@ -73,6 +130,12 @@ private static void

[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.

Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2714#discussion_r195243886 --- Diff: storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java --- @@ -73,6 +130,12 @@ private static void

[GitHub] storm pull request #2718: STORM-3103 allow nimbus to shutdown properly

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2718 STORM-3103 allow nimbus to shutdown properly Nimbus registers exitProcess() for the StormTimer.onKill routine. This does not return once called. This basically locks up the timer with active

[GitHub] storm issue #2715: STORM-3102 Remove check for partition offset before every...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2715 +1 ---

[GitHub] storm issue #2717: Bugfix/storm 3102 kafka client performance storm 1.x

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2717 +1. Please squash to one commit. ---

[GitHub] storm issue #2716: STORM-3102 Remove check for partition offset before every...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2716 +1 ---

[GitHub] storm pull request #2716: STORM-3102 Remove check for partition offset befor...

GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2716 STORM-3102 Remove check for partition offset before every emit. In kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git

[GitHub] storm pull request #2717: Bugfix/storm 3102 kafka client performance storm 1...

GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2717 Bugfix/storm 3102 kafka client performance storm 1.x In kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git repository by

[GitHub] storm pull request #2715: STORM-3102 Remove check for partition offset befor...

GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2715 STORM-3102 Remove check for partition offset before every emit. IN kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git

[GitHub] storm pull request #2712: Update Multilang-protocol.md

Github user MaurGi commented on a diff in the pull request: https://github.com/apache/storm/pull/2712#discussion_r195140675 --- Diff: docs/Multilang-protocol.md --- @@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0 # Storm

[GitHub] storm issue #2712: Update Multilang-protocol.md

Github user MaurGi commented on the issue: https://github.com/apache/storm/pull/2712 thanks for the feedback, modified and resubmitted - ---

[GitHub] storm issue #2714: STORM-3101: Add filter to StormMetricsRegistry.

Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2714 Some questions: 1. Currently, by rejecting a metric, StormMetricsRegistry simply discard it and log the warning without throwing any errors to the calling method/classes. Is this an

[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.

GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2714 STORM-3101: Add filter to StormMetricsRegistry. The current implementation is based on the idea to set a source for a certain process. All the metrics not belonging to the source (e.g.,

[GitHub] storm pull request #2713: [STORM-3094] : Added topology name validation at c...

GitHub user ManoharVanam opened a pull request: https://github.com/apache/storm/pull/2713 [STORM-3094] : Added topology name validation at client side Current Behavior : Execute topology with invalid topology name is throwing exception after uploading the jar. Improvement

[GitHub] storm pull request #2712: Update Multilang-protocol.md

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2712#discussion_r195078534 --- Diff: docs/Multilang-protocol.md --- @@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0 #

[GitHub] storm pull request #2703: [STORM-3094] : Added topology name validation at c...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2703 ---

[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2636 @cfriaszapater Ok, look forward to your master branch patch. ---

[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality

Github user cfriaszapater commented on the issue: https://github.com/apache/storm/pull/2636 Hi danny0405, In response to HeartSaVioR, I said: > I'll try to do that pull request in the future to master branch. > I did this to 1.1.x branch because we use it in our

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

Github user cfriaszapater closed the pull request at: https://github.com/apache/storm/pull/2636 ---