GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2750
STORM-3141: Fix NPE in WorkerState.transferLocalBatch, and refactor Bâ¦
â¦ackpressureTracker to get rid of placeholder JCQueue
https://issues.apache.org/jira/browse/STORM-3141
You can merge
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199600941
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199600468
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199578276
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199577394
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199574066
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
@revans2 Good point. It probably doesn't hurt much in the real code,
because the queue is only shut down when the worker or executor is shut down.
It could be an issue for tests with LocalCluster
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2747#discussion_r199566898
--- Diff:
storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java ---
@@ -52,7 +61,37 @@ public static void main(String[] args) throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199566175
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimedResource.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2743
I'm wondering how I should organized my code changes if I have some new
changes that depend on this PR but don't belong to this PR. Do I have to wait
until this PR has been merged? Or can I file
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199534448
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531884
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199531108
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2733
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2749
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2742
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2689
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199499960
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimerDecorated.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199497813
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/TimerDecoratedAssignment.java
---
@@ -0,0 +1,52 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199497485
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimedResource.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2745
I have two concerns about this fix.
1. We are doing something in the test that we are not doing anywhere in
the real code. If this is a bug in the test why are we not doing something
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2747#discussion_r199493660
--- Diff:
storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java ---
@@ -52,7 +61,37 @@ public static void main(String[] args) throws Exception
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2748
---
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2711
Sorry for not being able to address the comments sooner. Have been
traveling and should be able to get back to this soon after jul 12 th.
---
24 matches
Mail list logo
