Github user aniketalhat commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200802071
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicPartitionConnections.java
---
@@ -57,6 +57,7 @@ public SimpleConsumer
Github user aniketalhat commented on the issue:
https://github.com/apache/storm/pull/2755
@srdo I checked out my branch from master, I changed the target and we have
conflicts, obviously. Do you recommend checking out from 1.x ?
---
I’ll take a pass at reviewing them as well.
Thanks,
Hugo
> On Jul 6, 2018, at 1:41 PM, Jungtaek Lim wrote:
>
> Yeah I have been hoping that some other folks who are familiar with
> storm-kafka-client jump in and review in time, but unfortunately it didn't
> happen. Will try to review those PRs,
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2739
Should I also rebase it onto current master branch?
---
Yeah I have been hoping that some other folks who are familiar with
storm-kafka-client jump in and review in time, but unfortunately it didn't
happen. Will try to review those PRs, hopefully within couple of days.
Btw, if there're missing PRs to resolve STORM-2953
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
@HeartSaVioR Are you still planning on getting this in? I could probably
put some time in to trying this out if no one else is willing to test/use
storm-sql, so we can get a +1.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2726
---
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@srdo i think so, thanks for the review
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
Is this ready to merge @choojoyq?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200657323
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java ---
@@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()
Github user choojoyq commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200655178
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java ---
@@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200653436
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh() {
Github user choojoyq commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200651516
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh() {
Hi devs,
There are a couple of PRs open for changes in storm-kafka-client that would
be nice to get reviewed. The PRs are
https://github.com/apache/storm/pull/2652
https://github.com/apache/storm/pull/2648 and
https://github.com/apache/storm/pull/2590. If someone could find a couple
of minutes to
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
I guess this should target 1.0.x-branch, going by the listed commits.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
@aniketalhat I think you are targeting the wrong branch. You should target
the branch you started working on (e.g. 1.x-branch).
We can review 1.x first, but we'll also need a PR against master
GitHub user aniketalhat opened a pull request:
https://github.com/apache/storm/pull/2755
[WIP] STORM-3082 Add support to handle absent topics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aniketalhat/storm
17 matches
Mail list logo
