Stig,
I started reviewing your pull requests. There would be conflicts between
1.x-branch as well as conflicts between pull requests, so please follow up
some following-up requests if any.
Btw I'll rebase STORM-2406 to make it getting review again.
Thanks,
Jungtaek Lim (HeartSaVioR)
2018년 7월
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2648
@srdo
The patch wasn't applied to 1.x-branch cleanly. Could you please raise a PR
for 1.x-branch as well? Thanks in advance!
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2648
---
Github user aniketalhat commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200866147
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java
---
@@ -54,8 +57,12 @@ public
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2 @HeartSaVioR
Can you help me to review this again ? thx very much
---