Re: Requesting review for a couple of PRs

2018-07-08 Thread Jungtaek Lim
Stig, I started reviewing your pull requests. There would be conflicts between 1.x-branch as well as conflicts between pull requests, so please follow up some following-up requests if any. Btw I'll rebase STORM-2406 to make it getting review again. Thanks, Jungtaek Lim (HeartSaVioR) 2018년 7월

[GitHub] storm issue #2648: STORM-3013: Keep KafkaConsumer open when storm-kafka-clie...

2018-07-08 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2648 @srdo The patch wasn't applied to 1.x-branch cleanly. Could you please raise a PR for 1.x-branch as well? Thanks in advance! ---

[GitHub] storm pull request #2648: STORM-3013: Keep KafkaConsumer open when storm-kaf...

2018-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2648 ---

[GitHub] storm pull request #2755: STORM-3082 Add support to handle absent topics

2018-07-08 Thread aniketalhat
Github user aniketalhat commented on a diff in the pull request: https://github.com/apache/storm/pull/2755#discussion_r200866147 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java --- @@ -54,8 +57,12 @@ public

[GitHub] storm issue #2723: [STORM-3112] Incremental scheduling supports

2018-07-08 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2723 @revans2 @HeartSaVioR Can you help me to review this again ? thx very much ---