[GitHub] storm issue #2768: STORM-3156: Remove the transactional topology API

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2768 I don't see any use case on using transactional API (even when I start contribution on Apache Storm) so completely OK to remove, but feel safer to ask @revans2 to verify Bobby hasn't have use

Re: Regarding releasing Apache Storm 2.0.0

2018-07-18 Thread Jungtaek Lim
I'd like to say first, thanks Stig to take up remaining issues. Thanks to his efforts, according to the epic, we have only one major issue left: porting UI to Java [1], and pull request [2] is available for that. There're another issues [3] [4] targeting 2.0.0 (since it is backward incompatible)

[GitHub] storm pull request #2767: STORM-2953: Remove storm-kafka

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2767 ---

[GitHub] storm pull request #2766: STORM-2972: Replace storm-kafka with storm-kafka-c...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2766 ---

[GitHub] storm pull request #2766: STORM-2972: Replace storm-kafka with storm-kafka-c...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2766#discussion_r20357 --- Diff: docs/storm-sql-internal.md --- @@ -18,18 +18,16 @@ Figure 1 describes the workflow of executing a SQL query in StormSQL. First, use

[GitHub] storm pull request #2766: STORM-2972: Replace storm-kafka with storm-kafka-c...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2766#discussion_r203588814 --- Diff: docs/storm-sql-example.md --- @@ -291,9 +291,4 @@ That's it! Supposing we have UDF which queries geo location via remote ip, we ca

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

2018-07-18 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2618 Couple of comments back to @revans2 from Apr5. 1) We don't delete the blobs on the nimbus side for a while after we kill the topology. - Would we also prevent the user from doing so

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

2018-07-18 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2618 Just curious what the plan is fo this PR? ---

[GitHub] storm pull request #2768: STORM-3156: Remove the transactional topology API

2018-07-18 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2768 STORM-3156: Remove the transactional topology API https://issues.apache.org/jira/browse/STORM-3156 I'm not very familiar with the transactional topology API, so please let me know if I missed

[GitHub] storm issue #2767: STORM-2953: Remove storm-kafka

2018-07-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2767 Going to trigger another build, the previous one failed on the Java 10 runs due to a transient issue with Travis. ---

[GitHub] storm issue #2767: STORM-2953: Remove storm-kafka

2018-07-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2767 @danny0405 If you ignore the first commit and only look at changes from https://github.com/apache/storm/pull/2767/commits/29d98ccd1c775c58448dac2ed0010718113bfab8 it should be easier to manage. It's

[GitHub] storm issue #2767: STORM-2953: Remove storm-kafka

2018-07-18 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2767 @srdo Wow, the change is huge, i would take some time to review this patch. ---