GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2770
Trivial refactoring on DRPC
This should not change the code semantics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zd-project/storm
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2743
Can anyone, if available, help continue the review process of this PR? I
have more than 3 PR depending on this and counting. This makes rebasing a bit
hard for me. @HeartSaVioR @revans2 @srdo
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2769
Fixed a potential file resource leak.
The file is not properly put in the try-with-resource/try-finally block.
You can merge this pull request into a Git repository by running:
$ git pull
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2769
This will affect the implementation of #2754
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203863810
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203772574
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203770940
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203769516
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203769152
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203764174
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203763172
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203762570
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203761959
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203755133
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203754454
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723843
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203720155
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203717231
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723640
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203716797
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203724683
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r203693962
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -63,8 +60,6 @@ public static _Fields findByThriftId(int fieldId) {
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r203651733
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -63,8 +60,6 @@ public static _Fields findByThriftId(int fieldId) {
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2618
@agresch
Yeah , the problem still exists but i have no time to fix it now, i will
try to take it.
---
24 matches
Mail list logo