Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2782
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2780
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
change with `name()` is retained for now but have not been incorporated
into other PR dependents because I'm not clear if we'll benefit from this.
Should I remove this from PR for now and create
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2771
I have rebase this PR onto #2763, and I have also moved out
`registerMetricSet`, `unregisterMetricSet` and `registerTimer` to the
corresponding patch.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2763
All nits are addressed and PR is rebased on current master branch. Do you
want to merge this PR right now or merge this together with #2771?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2782
+1
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2780
+1
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2768
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2761
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r206266534
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,67 @@
@SuppressWarnings("unchecked")
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2765
There are still a few places in the UI and in some test code that look like
we are splitting on ":" to separate out a host from a port. This is not going
to work on raw IPv6 addresses. I would
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2752
localhost nimbus still does not show up on the UI if it is the only nimbus.
I am also getting an error in the visualization.
When hitting
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206240455
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/resources/StormApiResource.java
---
@@ -0,0 +1,702 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206238030
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/filters/AuthorizedUserFilter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206238984
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/resources/NimbusOp.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206235453
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIServer.java ---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206239558
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/resources/StormApiResource.java
---
@@ -0,0 +1,702 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206237782
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/filters/AuthorizedUserFilter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206236992
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/exceptionmappers/TExceptionMapper.java
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r206240201
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/ui/resources/StormApiResource.java
---
@@ -0,0 +1,702 @@
+/*
+ * Licensed to the
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2768
Sorry about my slow reply. I have been heads down on some other issues
lately. I do know of some people who have used the transaction API, but
Trident is the replacement for it. It uses the same
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2773#discussion_r206231780
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean downloadUpdatedBlob(Map
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2774
@jiangzhileaf I am trying to wrap my head around which situations would
cause this to happen. It appears that in some cases you can get a host name
from the network topography that has no
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2774#discussion_r206215796
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
---
@@ -357,9 +357,12 @@
Github user mal commented on the issue:
https://github.com/apache/storm/pull/2781
Solved by leveraging `log4j2`'s `isThreadContextMapInheritable` property.
---
Github user mal closed the pull request at:
https://github.com/apache/storm/pull/2781
---
Github user mal commented on the issue:
https://github.com/apache/storm/pull/2779
Solved by leveraging `log4j2`'s `isThreadContextMapInheritable` property.
---
Github user mal closed the pull request at:
https://github.com/apache/storm/pull/2779
---
28 matches
Mail list logo
