[GitHub] storm pull request #2812: STORM-3203: add back in the permission updates

2018-08-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2812#discussion_r212787574 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java --- @@ -230,6 +240,19 @@ public void commitNewVersion(long

[GitHub] storm pull request #2812: STORM-3203: add back in the permission updates

2018-08-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2812#discussion_r212787423 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java --- @@ -125,6 +129,12 @@ public long getRemoteVersion(Clien

[GitHub] storm pull request #2812: STORM-3203: add back in the permission updates

2018-08-24 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2812#discussion_r212787378 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java --- @@ -53,21 +54,24 @@ private final boolean isLo

[GitHub] storm issue #2809: STORM-3199: Remove metrics-ganglia due to LGPL dependency...

2018-08-24 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2809 Not sure what is happening but 'integration.org.apache.storm.integration-test' is constantly failing for me, and it failed in the travis run too. I'll try and see if I get the same results on regul

[GitHub] storm pull request #2807: STORM-3199: Remove metrics-ganglia due to LGPL dep...

2018-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2807 ---

Re: [DISCUSS] Remove Ganglia metrics reporter

2018-08-24 Thread Stig Rohde Døssing
Doesn't seem like there's any opposition to this. I think we can go ahead and merge https://github.com/apache/storm/pull/2807 in the next day or two. Den man. 20. aug. 2018 kl. 06.49 skrev Jungtaek Lim : > For Storm 2.0 I'm OK to drop supporting Ganglia reporter as same as why we > removed storm-