Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2812#discussion_r213125537
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java
---
@@ -53,21 +54,24 @@
private final boolean
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2809
@HeartSaVioR Sorry, I didn't get to this in time. I'll try to remember to
fix the nits next time there's a PR against 1.x.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2808#discussion_r213031503
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -1884,4 +1888,11 @@ public void setTopologyStrategy(String strategy) {
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2812
@danny0405 @HeartSaVioR
I think I answered your questions.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2812#discussion_r213030742
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java
---
@@ -125,6 +129,12 @@ public long
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2812#discussion_r213030220
--- Diff:
storm-server/src/main/java/org/apache/storm/localizer/LocallyCachedTopologyBlob.java
---
@@ -53,21 +54,24 @@
private final boolean
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2809
---
