[GitHub] storm pull request #2853: STORM-2963 Adding notes on GC to Performance.md

2018-09-28 Thread roshannaik
GitHub user roshannaik opened a pull request: https://github.com/apache/storm/pull/2853 STORM-2963 Adding notes on GC to Performance.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/roshannaik/storm STORM-2963 Alternatively yo

[GitHub] storm issue #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2852 @revans2 - added documentation ---

[GitHub] storm issue #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2852 Oh wait sorry. I forgot that we added docs for all of the metrics. Could you update docs/ClusterMetrics.md to include this too? ---

[GitHub] storm issue #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2852 @revans2 @kishorvpatil - made the change requested by Bobby. ---

[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2852#discussion_r221349119 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2162,7 +2165,12 @@ private boolean isReadyForMKAssignments() throws

[GitHub] storm pull request #2851: STORM-3236 mark shutdown meters before stopping me...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2851 ---

[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2852#discussion_r221331973 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2162,7 +2165,12 @@ private boolean isReadyForMKAssignments() throws

[GitHub] storm pull request #2850: [STORM-3235] Fix WorkerToken renewal criteria and ...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2850 ---

[GitHub] storm issue #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2852 @kishorvpatil - made the change you requested. ---

[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2852#discussion_r221288492 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2850,6 +2853,7 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2852#discussion_r221264813 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2850,6 +2853,7 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2852: STORM-3237 track Nimbus mkAssignment failures

2018-09-28 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2852#discussion_r221257606 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2850,6 +2853,7 @@ public void launchServer() throws Exception {