[GitHub] storm pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOff...

Github user janithkv commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234878772 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private voi

[GitHub] storm pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOff...

Github user janithkv commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234878731 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -137,7 +142,11 @@ public KafkaSpoutConfig(Bui

[GitHub] storm pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOff...

Github user janithkv commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234878746 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private voi

[GitHub] storm pull request #2904: add indent to log4j2 xml files

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2904 ---

[GitHub] storm pull request #2909: STORM-3123 - add support for Kafka security config...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2909 ---

[GitHub] storm issue #2904: add indent to log4j2 xml files

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2904 Thanks @chiba3, merged to master. ---

[GitHub] storm issue #2904: add indent to log4j2 xml files

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2904 +1. I think this is akin to a documentation change (formatting only), so doesn't need an issue filed for it. ---

Re: NullPointerException in KafkaOffsetMetric.getValueAndReset causing worker to die

It looks like KAFKA-7044 affects 1.1.0 and up, so people on earlier versions aren't affected. I think we should either make a work around for the issue by skipping the metrics if the bug occurs, or add a link to KAFKA-7044 to the documentation. Den man. 19. nov. 2018 kl. 09.42 skrev Alexandre Verm

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234541339 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -137,7 +142,11 @@ public KafkaSpoutConfig(Builder

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234542042 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private void em

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234541619 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private void em

Re: NullPointerException in KafkaOffsetMetric.getValueAndReset causing worker to die

Hello Stig, Thank you very much for your answer : I have tested our many topologies using Kafka Client 2.0.1 instead of Kafka Client 2.0.0, let them run at full charge for couple of days, and I can confirm that this exception no longer occurs ! May I suggest storm-kafka-client documentation to me