Hello Taylor,
Thank you very much for this Storm 1.2.3 release.
You did a great job to make this process running smoothly for many
releases; and I know that donating one's time on such large project is
a huge contribution.
Whatever you'll do next, may the code with be you!
Alexandre Vermeerberge
krichter722 opened a new pull request #3027: Remove JavadocMethod checkstyle
rule
URL: https://github.com/apache/storm/pull/3027
Remove JavadocMethod checkstyle rule because it requires tons of Javadocs to
be invented on files which are not touched for years and whose Javadoc can be
cover
srdo commented on issue #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#issuecomment-502389017
Okay, figured out the issue. The travis script builds storm-shaded-deps
first, separately from the rest of the build. This means storm-checkstyle isn't
build first,
srdo commented on issue #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#issuecomment-502388595
I think it's an issue inherited from
https://github.com/apache/storm/pull/3020/files, looks like it can't find the
storm/pmd-ruleset file added to config here
https
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055492
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +45,12 @@
krichter722 opened a new pull request #3026: Checkstyle jdbc examples
URL: https://github.com/apache/storm/pull/3026
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
krichter722 commented on issue #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#issuecomment-502388069
Can anyone tell me, why master builds and this branch doesn't because of
missing files in `storm-checkstyle` if nothing has been changed in the only
commit of
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055286
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java
##
@@ -15,27 +15,28 @@
* S
krichter722 commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055250
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +4
krichter722 commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294055135
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java
##
@@ -15,27 +15,28 @
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502387374
Ah right, sorry I misunderstood. You are right, that is painful.
This is an a
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294054906
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/ExampleJmsTopology.java
##
@@ -41,7 +45,12 @@
srdo commented on a change in pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025#discussion_r294054914
##
File path:
examples/storm-jms-examples/src/main/java/org/apache/storm/jms/example/GenericBolt.java
##
@@ -15,27 +15,28 @@
* S
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386844
Thanks.
> Regarding adjusting maxAllowedViolations, I don't see why it is painful?
You need to count how many viola
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386844
> Regarding adjusting maxAllowedViolations, I don't see why it is painful?
You need to count how many violations you fixed and ch
srdo merged pull request #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020
This is an automated message from the Apache Git Service.
To respond to the message, please log on
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386587
@krichter722 Yes, thanks for your patience.
Regarding adjusting maxAllowedViolations, I don't see why it is painful?
---
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214
@d2r #3025 covers some of the issues. Fixing one issue (whitespace, unused
variables, etc.) for all project requires the readjus
krichter722 edited a comment on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214
#3025 covers some of the issues. Fixing one issue (whitespace, unused
variables, etc.) for all project requires the readjustment
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502386214
#3025 covers some of the issues. Since fixing one issue for all project
requires the readjustment of maxAllowedViolations which is pain
krichter722 opened a new pull request #3025: Checkstyle jms examples
URL: https://github.com/apache/storm/pull/3025
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502383898
> it may be that the violations weren't caught because it didn't increase
the number of violations, or maybe the allowed count is too high
srdo commented on issue #2978: STORM-3311: Use Java 7 Files API for file IO
URL: https://github.com/apache/storm/pull/2978#issuecomment-502383599
This is ready for review, since Storm 2.0.0 has released.
This is an automated m
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502383408
@d2r The module has a number of allowed violations, it may be that the
violations weren't caught because it didn't increase the number of viola
d2r commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502383113
> I already did that for some projects. I'll open them soon.
That would be great!
I wanted to do three things:
* Normalize white-spa
krichter722 commented on issue #3020: [STORM-3000] Add missing @Override
annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502382161
> For this PR it is minor, and fixing the other white-space is out of scope
anyway. I'll follow up on this white-space separately.
Thank you Taylor..
On Sat, Jun 15, 2019 at 12:15 PM P. Taylor Goetz wrote:
> This vote is now closed and passes with 3 binding +1 votes and 1
> non-binding +1 vote.
>
> I will release the artifacts and create a release announcement.
>
> -Taylor
>
> > On May 10, 2019, at 12:20 PM, P. Taylor Goetz
This vote is now closed and passes with 3 binding +1 votes and 1 non-binding +1
vote.
I will release the artifacts and create a release announcement.
-Taylor
> On May 10, 2019, at 12:20 PM, P. Taylor Goetz wrote:
>
> This is a call to vote on releasing Apache Storm 1.2.3 (rc2)
>
> Full list
srdo commented on issue #3020: [STORM-3000] Add missing @Override annotations
URL: https://github.com/apache/storm/pull/3020#issuecomment-502378681
+1
This is an automated message from the Apache Git Service.
To respond to the
29 matches
Mail list logo
