[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r388018463 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] Ethanlm opened a new pull request #3220: [STORM-3594] Add checkstyle rule WhitespaceAfter

Ethanlm opened a new pull request #3220: [STORM-3594] Add checkstyle rule WhitespaceAfter URL: https://github.com/apache/storm/pull/3220 https://issues.apache.org/jira/browse/STORM-3594 This rule has been exercised during code review. Adding it to reduce human efforts -

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r388000583 ## File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java #

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387966130 ## File path: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ##

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387940338 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387938745 ## File path: storm-client/src/jvm/org/apache/storm/Config.java ## @@ -304,11

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387938501 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387930157 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387927220 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] RuiLi8080 commented on issue #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

RuiLi8080 commented on issue #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#issuecomment-594812990 @kishorvpatil Thanks for your review. As I addressed your comment,

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387904802 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387902678 ## File path: storm-client/src/jvm/org/apache/storm/Config.java ## @@ -304,11

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387895854 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387886374 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387885841 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/sch

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387881828 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387884472 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/sch

[GitHub] [storm] Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387881742 ## File path: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ## @@

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387881828 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

Ethanlm commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387880639 ## File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java #

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387880032 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387879241 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387874239 ## File path: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ##

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387872435 ## File path: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ##

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387823684 ## File path: storm-server/src/main/jav

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387823536 ## File path: storm-server/src/main/jav

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387823631 ## File path: storm-server/src/main/java

[GitHub] [storm] RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

RuiLi8080 commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387816618 ## File path: storm-server/src/main/java

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387780751 ## File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java #

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387780751 ## File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java #

[GitHub] [storm] bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

bipinprasad commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387778133 ## File path: storm-client/src/jvm/org/apache/storm/validation/ConfigValidation.java #

[GitHub] [storm] kishorvpatil commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt

kishorvpatil commented on a change in pull request #3215: Storm3585 - New compact Constraint config including maxCoLocationCnt URL: https://github.com/apache/storm/pull/3215#discussion_r387757114 ## File path: storm-client/src/jvm/org/apache/storm/Config.java ## @@ -304,11

[GitHub] [storm] Ethanlm opened a new pull request #3219: [STORM-3494] Use UserGroupInformation to login to HDFS only once per process

Ethanlm opened a new pull request #3219: [STORM-3494] Use UserGroupInformation to login to HDFS only once per process URL: https://github.com/apache/storm/pull/3219 `HadoopLoginUtil.loginHadoop(conf);` should be used when login to hadoop from Storm daemons. Rework https://github.com

[GitHub] [storm] Ethanlm closed pull request #3189: [STORM-3494] use HdfsLoginUtil singleton to login to hdfs

Ethanlm closed pull request #3189: [STORM-3494] use HdfsLoginUtil singleton to login to hdfs URL: https://github.com/apache/storm/pull/3189 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm] kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and…

kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and… URL: https://github.com/apache/storm/pull/3217#discussion_r387721854 ## File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strateg

[GitHub] [storm] kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and…

kishorvpatil commented on a change in pull request #3217: STORM-3590: Adds test to validate that GRAS's node sort is stable and… URL: https://github.com/apache/storm/pull/3217#discussion_r387720778 ## File path: storm-server/src/main/java/org/apache/storm/scheduler/Topologies.java

[GitHub] [storm] kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387631007 ## File path: storm-server/src/main/

[GitHub] [storm] kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387630064 ## File path: storm-server/src/main/

[GitHub] [storm] kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387632643 ## File path: storm-server/src/main/

[GitHub] [storm] kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387630206 ## File path: storm-server/src/main/j

[GitHub] [storm] kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

kishorvpatil commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies URL: https://github.com/apache/storm/pull/3213#discussion_r387629493 ## File path: storm-server/src/main/j