[GitHub] [storm] bipinprasad commented on pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0

bipinprasad commented on PR #3496: URL: https://github.com/apache/storm/pull/3496#issuecomment-1287558076 This will need some code change: change class org.apache.storm.thrift.transport.TFramedTransport --> org.apache.storm.thrift.transport.layered.TFramedTransport And some othe

[GitHub] [storm] bipinprasad commented on a diff in pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0

bipinprasad commented on code in PR #3496: URL: https://github.com/apache/storm/pull/3496#discussion_r1002255399 ## external/storm-hive/pom.xml: ## @@ -202,7 +201,7 @@ org.apache.thrift libthrift - 0.9.3 + 0.14.0 Review Comment: Can this use

[GitHub] [storm] bipinprasad commented on pull request #3498: fix(sec): upgrade org.elasticsearch:elasticsearch to 6.8.17

bipinprasad commented on PR #3498: URL: https://github.com/apache/storm/pull/3498#issuecomment-1287523290 Probably needs some code change. https://app.travis-ci.com/github/apache/storm/jobs/585564257 line 6680 Error in external/storm-elasticsearch/src/test/java/org/apache/storm/elastic

[GitHub] [storm] bipinprasad commented on pull request #3501: [STORM-3885] fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1

bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287522460 Probably needs some code change. https://app.travis-ci.com/github/apache/storm/jobs/585564257 line 6680 Error in external/storm-elasticsearch/src/test/java/org/apache/storm/elastic

[GitHub] [storm] bipinprasad commented on pull request #3500: fix(sec): upgrade com.google.guava:guava to 30.0-jre

bipinprasad commented on PR #3500: URL: https://github.com/apache/storm/pull/3500#issuecomment-1287511964 DEPENDENCY-LICENSES needs to be changed as well. License check failed https://app.travis-ci.com/github/apache/storm/jobs/585571698 line 3190 -- This is an automated message fro

[GitHub] [storm] bipinprasad commented on pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13

bipinprasad commented on PR #3494: URL: https://github.com/apache/storm/pull/3494#issuecomment-1287508449 For license failures, you can check the output. There will be current file vs expected file. Diff will show what needs to be changed in DEPENDENCY-LICENSES file. -- This is an automa

[GitHub] [storm] bipinprasad commented on pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13

bipinprasad commented on PR #3494: URL: https://github.com/apache/storm/pull/3494#issuecomment-1287507110 Seems like a good fix. Any reason why this PR should be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [storm] bipinprasad commented on pull request #3501: [STORM-3885] fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1

bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287457886 https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind shows that 2.12.6.1 has two different vulnerabilities: Direct vulnerabilities: [CVE-2022-42004](htt

[GitHub] [storm] bipinprasad commented on pull request #3501: fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1

bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287441366 Looks like this needs some code change since the class com/fasterxml/jackson/core/util/JacksonFeature is not found. -- This is an automated message from the Apache Git Service. To res

[GitHub] [storm] bipinprasad commented on pull request #3491: [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0

bipinprasad commented on PR #3491: URL: https://github.com/apache/storm/pull/3491#issuecomment-1287439674 Created Jira https://issues.apache.org/jira/browse/STORM-3884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [storm] bipinprasad merged pull request #3502: [STORM-3883] Update Kryo to version 4.0.2

bipinprasad merged PR #3502: URL: https://github.com/apache/storm/pull/3502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache