Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671733875 Thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad merged PR #3526: URL: https://github.com/apache/storm/pull/3526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
rzo1 commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671693360 I cleaned it up, so we are mergable again. However, I want to check if we better use the kyro5 artifact as shade replacement: https://groups.google.com/g/kryo-users/c/hVlwHmBE_-s

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288790275 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288789046 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
agresch commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288728408 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] [STORM-3884] Update calcite to 1.16.0 (storm)

2023-08-09 Thread via GitHub
rzo1 merged PR #3510: URL: https://github.com/apache/storm/pull/3510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.7.x but I

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.7.x --

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.8.x --

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
aishwaryasoni1991 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288246796 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: The Zookeeper community has

[PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 opened a new pull request, #3560: URL: https://github.com/apache/storm/pull/3560 ## What is the purpose of the change - Replace EOL Zookeeper with modern Zookeeper version. - Updates Curator - Note: Exhibitor support is dropped in modern curator -- This is an automated