bipinprasad commented on code in PR #3572:
URL: https://github.com/apache/storm/pull/3572#discussion_r1309775684
##
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java:
##
@@ -333,11 +330,16 @@ public void testNextByteOffsetsAr
bipinprasad commented on code in PR #3572:
URL: https://github.com/apache/storm/pull/3572#discussion_r1309769830
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/normalization/NormalizedResourceRequest.java:
##
@@ -20,15 +20,15 @@
import java.util.HashMap;
i
bipinprasad commented on code in PR #3572:
URL: https://github.com/apache/storm/pull/3572#discussion_r1309762319
##
pom.xml:
##
@@ -854,6 +855,11 @@
javax.servlet-api
${servlet.version}
+
Review Comment:
Do we still
bipinprasad opened a new pull request, #3576:
URL: https://github.com/apache/storm/pull/3576
## What is the purpose of the change
*Specify the default location of generated sources. This allows IDEs like
eclipse to generate, detect, and load generated classes*
## How was the ch
bipinprasad opened a new pull request, #3575:
URL: https://github.com/apache/storm/pull/3575
## What is the purpose of the change
*mvn test warns of illegal reflection in jdk11+*
## How was the change tested
*Unit test and github actions*
--
This is an automated messag
Hello Julien,
Here's the precise version of Eclipse IDE which I am using:
==
Eclipse IDE for Java Developers (includes Incubating components)
Version: 2023-06 (4.28.0)
Build id: 20230608-1333
=
bipinprasad opened a new pull request, #3574:
URL: https://github.com/apache/storm/pull/3574
## What is the purpose of the change
*Allow explicit reflection permission for use in JDK11 and above*
## How was the change tested
*Run mvn test; activate github actions*
--
T
agresch commented on code in PR #3573:
URL: https://github.com/apache/storm/pull/3573#discussion_r1309194992
##
storm-shaded-deps/pom.xml:
##
@@ -337,7 +336,7 @@
-->
org.codehaus.mojo
build-helper-maven-plugin
-3
bipinprasad opened a new pull request, #3573:
URL: https://github.com/apache/storm/pull/3573
## What is the purpose of the change
*Importing Storm into eclipse and a maven project shows some errors and
warnings*
## How was the change tested
*Import into eclipse as well a
As a first time user of eclipse on Storm project, I did encounter a lot "red"
compile error issues.Most of them go away when I built the storm-shaded-deps
project separately, added eclipse m2e plugin for the lifecycle management
setting, and then selected the sub-project and in the context menu
Hi Alexandre
I use Eclipse and have imported Storm with Import -> Existing Maven project
etc.. but am not getting the error message you mentioned. Which version of
Eclipse are you using?
I then get tons of compilation errors, like you do.
Julien
On Mon, 28 Aug 2023 at 02:23, Alexandre Vermeerbe
That's perfect, thanks Richard!
On Mon, 28 Aug 2023 at 15:34, Richard Zowalla wrote:
> Hi all,
>
> we (Julien, Alexandre and myself) have been discussing about the future
> of the /external modules in Storm over in Slack (#Storm). As Slack
> isn't the place for any decisions at the ASF, we are n
12 matches
Mail list logo
