[PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
bipinprasad opened a new pull request, #3578: URL: https://github.com/apache/storm/pull/3578 ## What is the purpose of the change *storm-sql-core extract javacc parser definition from Calcite jar, adds it to distribution, then used javacc to generate classes that parser definition fi

Re: Any clue to import Storm's pom.xml in Eclipse for contributing purposes?

2023-09-01 Thread Bipin Prasad
Hello Alexandre, I spent some time trying to tweak the storm-cassandra pom.xml. Although this will end up in a pull request, the actual error in eclipse about "The package java.util is accessible from more than one module: , java.base" will remain. I might try one or two other things today,

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
avermeer commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565 I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes). May I merge it ? -- Th

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread Alexandre Vermeerbergen
And by the way, after copying the changes from STORM-3970 (and closing storm-cassandra project, for which I'm anticipating low community interest, so I'm skipping it), I only have 3 errors left in Eclipse IDE for Storm: On /storm-client/pom.xml: line 206 (which just contains tag) error message i

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread Bipin Prasad
Yes, I have fixes for those. They will be up there shortly. But at least you are up and running and can use the power of UI. One thing surprised me with the latest eclipse - it is very easy for the Editor to get confused about the content of a file (and loose the trailing end of a file). I had t

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
rzo1 commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703016184 Go ahead + close the Jira 🫠 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
avermeer merged PR #3578: URL: https://github.com/apache/storm/pull/3578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.or

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
avermeer commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703022984 Merging done! But I cannot close the JIRA https://issues.apache.org/jira/projects/STORM/issues/STORM-3970?filter=allopenissues, as it is owned by Bipin. -- This is an automat

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread Alexandre Vermeerbergen
Hi Bipin, That will be wonderful if you find the way to fix these last 3 errors in pom.xml files, thanks !! By the way, I never experienced Eclipse IDE being confused about files' content : just make sure if you edit the file outside Eclipse IDE to use "Refresh" (when I doubt, I select all projec

Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)

2023-09-01 Thread via GitHub
rzo1 commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703064106 I closed it. With the addition to the PMC, you should have enough Karma for Jira stuff. If not, we need to check. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] STORM-3961 - Modernize Storm-UI Dependencies (storm)

2023-09-01 Thread via GitHub
bipinprasad merged PR #3572: URL: https://github.com/apache/storm/pull/3572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)

2023-09-01 Thread via GitHub
bipinprasad commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313311313 ## storm-shaded-deps/pom.xml: ## @@ -337,7 +336,7 @@ --> org.codehaus.mojo build-helper-maven-plugin -

Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)

2023-09-01 Thread via GitHub
bipinprasad commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313314450 ## storm-shaded-deps/pom.xml: ## @@ -358,5 +357,34 @@ + + + + +

Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)

2023-09-01 Thread via GitHub
rzo1 commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313319589 ## storm-shaded-deps/pom.xml: ## @@ -358,5 +357,34 @@ + + + + +