[GitHub] storm pull request #2287: [STORM-2699] Put all the version information of th...

2017-08-21 Thread BigOneLiu
GitHub user BigOneLiu opened a pull request: https://github.com/apache/storm/pull/2287 [STORM-2699] Put all the version information of third party component into the main pom [https://issues.apache.org/jira/browse/STORM-2699](https://issues.apache.org/jira/browse/STORM-2699

[GitHub] storm issue #2287: [STORM-2699] Put all the version information of third par...

2017-08-21 Thread BigOneLiu
Github user BigOneLiu commented on the issue: https://github.com/apache/storm/pull/2287 @HeartSaVioR Could you please review my pr? thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #2377: [STORM-2780] MetricsConsumer record unnecessary ti...

2017-10-17 Thread BigOneLiu
GitHub user BigOneLiu opened a pull request: https://github.com/apache/storm/pull/2377 [STORM-2780] MetricsConsumer record unnecessary timestamp @revans2 Could you please review my pr? thx You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm issue #2377: [STORM-2780] MetricsConsumer record unnecessary timestamp

2017-10-17 Thread BigOneLiu
Github user BigOneLiu commented on the issue: https://github.com/apache/storm/pull/2377 @vesense Could you please review my pr? If it could be an improvement? ---

[GitHub] storm issue #2377: [STORM-2780] MetricsConsumer record unnecessary timestamp

2017-10-18 Thread BigOneLiu
Github user BigOneLiu commented on the issue: https://github.com/apache/storm/pull/2377 Actually you can easily get the taskInfo.timestamp(1508207360) from thr date (2017-10-17 10:29:20) ,and Log4j framework has provided more accurate date(2017-10-17 10:29:20,906 126908). If

[GitHub] storm issue #2377: [STORM-2780] MetricsConsumer record unnecessary timestamp

2017-10-23 Thread BigOneLiu
Github user BigOneLiu commented on the issue: https://github.com/apache/storm/pull/2377 @revans2 like you said 99.9% of the time they are the same,and if the tuple is delayed by 1 second,it's a big problem for storm.maybe you don't need this data then. vesense's c