[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-02 Thread RPCMoritz
Github user RPCMoritz commented on the issue: https://github.com/apache/storm/pull/2248 @HeartSaVioR since you helped out with this issue previously - can we get some committer attention to this PR? LGTM quickly. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

2017-07-31 Thread RPCMoritz
Github user RPCMoritz commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r130360205 --- Diff: external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java --- @@ -92,3 +115,27 @@ public void cleanup

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

2017-07-31 Thread RPCMoritz
Github user RPCMoritz commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r130362674 --- Diff: external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java --- @@ -80,6 +85,24 @@ public void testInsertAndSelect

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

2017-07-31 Thread RPCMoritz
Github user RPCMoritz commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r130360350 --- Diff: external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java --- @@ -92,3 +115,27 @@ public void cleanup

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

2017-07-31 Thread RPCMoritz
Github user RPCMoritz commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r130360392 --- Diff: external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java --- @@ -92,3 +115,27 @@ public void cleanup

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

2017-07-31 Thread RPCMoritz
Github user RPCMoritz commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r130361066 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -223,13 +237,25 @@ private void