[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-13 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-62875666 Thanks for merging, Sean! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-12 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-62714754 Guys, it there any update on this pull request? As for me, the bug it fixes is rather critical and the fix is simple enough (without refactoring, etc) to be merged

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-06 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61949580 @harshach > Is there anything changed in storm-core/test/clj/backtype/storm/messaging/netty_unit_test.clj Since I've removed overcomplicated t

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-04 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61764038 Thanks for the review, @clockfly I have added necessary comment and removed the tests. Sorry, I wasn't able to simplify them - if they were in s

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-10-31 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61273506 Thanks, @HeartSaVioR @ptgoetz, @revans2, @jason_j, @anfeng, @mrflip, @davidlao2k, @ptgoetz, @revans2, @miguno, @kishorvpatil, could anyone of you review this

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-10-31 Thread Sergeant007
Github user Sergeant007 commented on a diff in the pull request: https://github.com/apache/storm/pull/304#discussion_r19671046 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -153,6 +153,7 @@ private synchronized void connect

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-10-31 Thread Sergeant007
Github user Sergeant007 commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61226979 @d2r , @harshach , @HeartSaVioR Could you, please, take a look on this pull request? --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-10-29 Thread Sergeant007
GitHub user Sergeant007 opened a pull request: https://github.com/apache/storm/pull/304 [STORM-537] A worker reconnects infinitely to another dead worker A fix for [STORM-537](https://issues.apache.org/jira/browse/STORM-537). The bug is that a worker reconnects to another dead