[GitHub] storm pull request: STORM-702: Exhibitor support

2016-01-08 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-170156299 I've tested this fix against the latest code (see thread above for how I am testing). Anything else to consider? I've notice

[GitHub] storm pull request: STORM-702: Exhibitor support

2016-01-05 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-169162327 @revans2 i've rebased and made updates per cr. mvn tests are passing. will try to test full integration scenario tomorrow. --- If your project is set up for it, yo

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-17 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-82580384 @harshach implemented your suggestions, thank you. The *storm* configuration I used to test (w/ single zk node, too) is in the first comment of this thread

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-12 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-78764060 The config is optional. If not present, everything works as usual. On Thu, Mar 12, 2015 at 9:18 PM, Harsha wrote: > @atdixon @revans2 with this patch

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-11 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-78415948 Note: I've added a short bit on design options and why I recommend this implementation in a comment attached to the JIRA ticket. --- If your project is set up f

[GitHub] storm pull request: STORM-702: Exhibitor support

2015-03-11 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-78386437 Done, I've added the ticket number to the title. Here is the ticket: https://issues.apache.org/jira/browse/STORM-702 --- If your project is set up for it, you can

[GitHub] storm pull request: Exhibitor support

2015-02-16 Thread atdixon
Github user atdixon commented on the pull request: https://github.com/apache/storm/pull/432#issuecomment-74537246 Zookeeper and its clients require static list of hosts in its configuration [1]. Exhibitor (in addition to supervision, backup, etc.) can provide the Zookeeper server

[GitHub] storm pull request: Exhibitor support

2015-02-15 Thread atdixon
GitHub user atdixon opened a pull request: https://github.com/apache/storm/pull/432 Exhibitor support This introduces optional exhibitor configuration properties to storm config--the options parallel the zookeeper options where relevant: storm.exhibitor.servers