[GitHub] storm issue #2473: [STORM-2868] Address handling activate/deactivate in mult...

2017-12-26 Thread bitcloud
Github user bitcloud commented on the issue: https://github.com/apache/storm/pull/2473 way better. updated and created issue. hope we are all set now ;-) ---

[GitHub] storm issue #2473: Update multilang module files for new multilang protocol

2017-12-26 Thread bitcloud
Github user bitcloud commented on the issue: https://github.com/apache/storm/pull/2473 You are very right. It just felt that those modules pretty much fly unter the radar, as there are no testcases as well currently. Will create an jira account and submit an issue. I checked

[GitHub] storm issue #2473: Update multilang modules

2017-12-26 Thread bitcloud
Github user bitcloud commented on the issue: https://github.com/apache/storm/pull/2473 hey @HeartSaVioR I checked those before and thought this finding applies to `For small patches, feel free to submit pull requests directly for those patches.` so there is no need for a jira

[GitHub] storm pull request #2473: Update multilang modules

2017-12-26 Thread bitcloud
Github user bitcloud commented on a diff in the pull request: https://github.com/apache/storm/pull/2473#discussion_r158701040 --- Diff: storm-multilang/ruby/src/main/resources/resources/storm.rb --- @@ -205,6 +205,10 @@ class Spout def open(conf, context); end

[GitHub] storm issue #2473: Update multilang modules

2017-12-19 Thread bitcloud
Github user bitcloud commented on the issue: https://github.com/apache/storm/pull/2473 I stumbled over that while playing around with the 1.1.x branch, so you probably need to merge that to those branches as well. Not quite sure since when the new protocol is in place. ---

[GitHub] storm pull request #2473: Update multilang modules

2017-12-19 Thread bitcloud
GitHub user bitcloud opened a pull request: https://github.com/apache/storm/pull/2473 Update multilang modules As it is now required to answer to the activation and deactivation, I added those to the javascript files because the examples stopped working. I updated ruby and