[GitHub] storm pull request: STORM-1071 Task Message format to include sour...

2015-10-16 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/803#issuecomment-148811510 I see with present changes, when I performed the unit test, netty ```test-basic``` and ```test-large-msg``` work fine but ```test-batch``` fails if we go over 1000

[GitHub] storm pull request: STORM-1071 Task Message format to include sour...

2015-10-16 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/803#issuecomment-148789458 I see I should be updating netty_unit_test.clj to prevent the Travis CI build failures. I shall push an update soon. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-1071 Task Message format to include sour...

2015-10-15 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/803 STORM-1071 Task Message format to include source task id As part of gathering inputs for Resource Aware Scheduler, understanding the tuple network characteristics between tasks would be helpful

[GitHub] storm pull request: STORM-1071 : Task Message format to include so...

2015-10-01 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/768#issuecomment-144833931 There seems to be a problem with workers dying if the topology is left to run for long time. I shall debug and open a new pull request after merging with master

[GitHub] storm pull request: STORM-1071 : Task Message format to include so...

2015-10-01 Thread bourneagain
Github user bourneagain closed the pull request at: https://github.com/apache/storm/pull/768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1071 : Task Message format to include so...

2015-09-29 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/768 STORM-1071 : Task Message format to include source task id. As part of gathering inputs for Resource Aware Scheduler, understanding the tuple network characteristics between tasks would be

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

2015-08-19 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/608#issuecomment-132722067 *** PLEASE DO NOT MERGE THIS YET More information @ https://issues.apache.org/jira/browse/STORM-919. --- If your project is set up for it, you can reply

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

2015-08-04 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/608#issuecomment-127623505 I will revert the changes to Thrift generated files and update the pull request. Also I have updated details on how we plan to use these metrics @ https

[GitHub] storm pull request: STORM-918 Storm CLI could validate arguments/p...

2015-07-17 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/632#issuecomment-122483857 Thanks for the comments, I understand the implication now and have changed the code accordingly. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: STORM-918 Storm CLI could validate arguments/p...

2015-07-14 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/632 STORM-918 Storm CLI could validate arguments/print usage Storm commands that mandate proper args to be passed would now throw the function's doc string as help rather than exiting out

[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...

2015-07-14 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/593#issuecomment-121281726 Thanks @HeartSaVioR .We can have this merged to master whenever we feel appropriate. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-13 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-120938865 Thank you @HeartSaVioR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-10 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-120450816 @HeartSaVioR Thanks. Can this be merged into the master now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...

2015-07-06 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/593#issuecomment-118856776 I am working on few more review comments presently and shall update as soon as its available for further review. Thanks! --- If your project is set up for it, you

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

2015-07-05 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/608#issuecomment-118634483 Thanks @lazyval . I shall keep that in mind going forward. For review we can omit all those under the "generated" directory. --- If your project is set

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-05 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-118633914 Thanks @HeartSaVioR . I apologize for the mistake. I have now removed the local debug I had put on during testing. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-05 Thread bourneagain
Github user bourneagain commented on a diff in the pull request: https://github.com/apache/storm/pull/575#discussion_r33894593 --- Diff: storm-core/src/jvm/backtype/storm/utils/ShellProcess.java --- @@ -48,8 +50,31 @@ public ShellProcess(String[] command

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-03 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-118387380 Thanks @HeartSaVioR . I have fixed the imports issue and tested on local machine to see it working fine. I shall keep a note of this in future. Thanks. --- If your

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-07-01 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-11990 Thanks Derek for the comments. I have now pushed in the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

2015-06-30 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/608 STORM-919 Gathering worker and supervisor process information (CPU/Memory) - Changes to the worker and supervisor heartbeats to carry the system stats ( CPU util % and JVM memory stats in KB

[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...

2015-06-12 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/593 STORM-67 Provide API for spouts to know how many pending messages there are You can merge this pull request into a Git repository by running: $ git pull https://github.com/bourneagain

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-06-11 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-51124 Thanks HeartSavior. I have cleaned up the commit history now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-06-09 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-110366648 The changes to ShellSpout have been committed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-06-05 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-109361408 Thanks HeartSaVioR. Yes we can apply this to ShellSpout as well. I will do the changes shortly. --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-06-04 Thread bourneagain
Github user bourneagain commented on the pull request: https://github.com/apache/storm/pull/575#issuecomment-108958705 The build failure seems to be only with JDK 7 during the **storm.kafka.TridentKafkaTest** ` [main] ERROR kafka.producer.async.DefaultEventHandler - Failed

[GitHub] storm pull request: STORM-160 Allow ShellBolt to set env vars (par...

2015-06-03 Thread bourneagain
GitHub user bourneagain opened a pull request: https://github.com/apache/storm/pull/575 STORM-160 Allow ShellBolt to set env vars (particularly PATH) Support to allow ShellBolt to set environment variables Example : WordCountTopology.java
builder.setBolt("