[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-05-27 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-78362 Following the Trident API support for the new KafkaSpout implementation... Is anyone working on this? Thanks. --- If your project is set up for it, you can reply

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-04-01 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-204615040 +1 for merging and thanks for work @hmcl. @hmcl The previous KafkaSpout implementation publishes a kafkaOffset metrics to track spout lag, latest time offset

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-28 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-202527934 @harshach @revans2 @abhishekagarwal87 Any comments? @hmcl Thanks for the work. I assume that this does not have the required changes for Trident. So, would

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-02-29 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-190326611 @revans2 @tgravescs , comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-02-22 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-187287074 +1 on Trident support. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-02-08 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-181711832 @hmcl, any update to your patch? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-01-21 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-173744934 I too agree that STORM-1015 is beyond the scope of Kafka 0.9 uprev related changes. So, I think it makes sense to keep them separate. @hmcl, any ETA

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-01-20 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-173354953 @hmcl Will your PR include the rev for Trident API to work with Kafka 0.9? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-01-06 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-169437497 That's great! When will this pull request be merged to master? We need it as well. Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API

2016-01-06 Thread connieyang
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-169458814 Excellent! I will follow @hmcl for his PR. Thanks for the update! --- If your project is set up for it, you can reply to this email and have your reply appear