[GitHub] storm pull request #1567: [STORM-1973] Using DefaultTopicSelector to replace...

2016-10-28 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1604: [STORM-2013] Upgrade Netty to 3.10.6

2016-09-25 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1604 @HeartSaVioR OK maybe move to netty 4 is better thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #1604: [STORM-2013] Upgrade Netty to 3.10.6

2016-09-25 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1590: [STORM-2003] Make sure config contains TOPIC befor...

2016-08-02 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1590#discussion_r73194225 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java --- @@ -98,7 +98,11 @@ public void prepare(Map stormConf

[GitHub] storm pull request #1604: [STORM-2013] Upgrade Netty to 3.10.6

2016-08-02 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1604 [STORM-2013] Upgrade Netty to 3.10.6 [STORM-2013 Upgrade Netty to 3.10.6](https://issues.apache.org/jira/browse/STORM-2013) Since Netty 3.9 , it have fix some bugs and improve

[GitHub] storm issue #1603: STORM-2012: Upgrade Kafka to 0.8.2.2

2016-08-02 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1603 @vesense could you describe what is update with `Kafka 0.8.2.2` ? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1555: [Storm 1963] Replace Put add with addColumn

2016-07-31 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1555: [Storm 1963] Replace Put add with addColumn

2016-07-31 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1555 Yes It's duplicated with `STORM-1726` and I close this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1587: [STORM-1991] Support auto.commit.interval in Kafka...

2016-07-26 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1587: [STORM-1991] Support auto.commit.interval in Kafka Client

2016-07-26 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1587 Hi @hmcl `auto.commit.interval.ms` is the interval to committed offset into zookeeper and it default value is `60 * 1000 (1S)`. I found there is a constant in `KafkaSpoutConfig .Consumer

[GitHub] storm issue #1554: adjusted Flux documentation to show new flux-wrapper libr...

2016-07-25 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1554 Looks Good To Me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] storm pull request #1590: [STORM-2003] Make sure config contains TOPIC befor...

2016-07-25 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1590 [STORM-2003] Make sure config contains TOPIC before get it [STORM-2003 Make sure config contains TOPIC before get it](https://issues.apache.org/jira/browse/STORM-2003) When topic

[GitHub] storm pull request #1589: [STORM-2002] KafkaSpout data type error

2016-07-24 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1589: [STORM-2002] KafkaSpout data type error

2016-07-24 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1589 [STORM-2002] KafkaSpout data type error [STORM-2002 KafkaSpout data type error](https://issues.apache.org/jira/browse/STORM-2002) KafkaConsumer seekToBeginning and seekToEnd is using

[GitHub] storm pull request #1587: [STORM-1991] Support auto.commit.interval in Kafka...

2016-07-24 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1587 [STORM-1991] Support auto.commit.interval in Kafka Client [STORM-1991 Support auto.commit.interval in Kafka Client](https://issues.apache.org/jira/browse/STORM-1991) Support

[GitHub] storm issue #1569: [STORM-1974] Using System.lineSeparator to replacement wr...

2016-07-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1569 @ptgoetz This's just graceful than write twice . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request #1580: [STORM-1990] Make some constant unvisible

2016-07-20 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1580 [STORM-1990] Make some constant unvisible [STORM-1990 Make some constant unvisible](https://issues.apache.org/jira/browse/STORM-1990) Some constant used as default config , make them

[GitHub] storm pull request #1566: [STORM-1971] HDFS Timed Synchronous Policy

2016-07-18 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1566#discussion_r71182808 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/sync/CountSyncPolicy.java --- @@ -26,7 +26,7 @@ * have been processed

[GitHub] storm issue #1570: [STORM-1975] Support default value for KafkaBolt

2016-07-17 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1570 @harshach `Storm-kafka-client` is a new spout to consume data from Kafka . It seems not include `KafkaBolt`. Is it good to port `Storm-kafka`'s `KafkaBolt` into `Storm-kafka-c

[GitHub] storm pull request #1570: [STORM-1975] Support default value for KafkaBolt

2016-07-16 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1570 [STORM-1975] Support default value for KafkaBolt [STORM-1975 Support default value for KafkaBolt](https://issues.apache.org/jira/browse/STORM-1975) Support some default values (acks

[GitHub] storm pull request #1569: [STORM-1974] Using System.lineSeparator to replace...

2016-07-16 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1569 [STORM-1974] Using System.lineSeparator to replacement write a new line [STORM-1974 : Using System.lineSeparator to replacement write a new line](https://issues.apache.org/jira/browse/STORM

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70835839 --- Diff: storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java --- @@ -31,13 +31,13 @@ * Returns the length of the

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70834283 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java --- @@ -26,10 +26,10 @@ * @param the type of event tracked by

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70832297 --- Diff: storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java --- @@ -66,10 +66,14 @@ public String toString() { * Holds a

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70831175 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt

[GitHub] storm issue #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1527 @arunmahadevan why don't have `@isLong` ? millisecond using it to decorate is better --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] storm pull request #1567: [STORM-1973] Using DefaultTopicSelector to replace...

2016-07-14 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1567 [STORM-1973] Using DefaultTopicSelector to replace StaticTopicSelector [Using DefaultTopicSelector to replace StaticTopicSelector](https://issues.apache.org/jira/browse/STORM-1973

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1565 What is it doing ? Do you add more desc ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #1566: [STORM-1971] HDFS Timed Synchronous Policy

2016-07-14 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1566 [STORM-1971] HDFS Timed Synchronous Policy [STORM-1971 HDFS Timed Synchronous Policy](https://issues.apache.org/jira/browse/STORM-1971) When the data need to be wrote to HDFS is not

[GitHub] storm pull request #1555: [Storm 1963] Replace Put add with addColumn

2016-07-12 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1555 [Storm 1963] Replace Put add with addColumn [STORM-1963 Replace Put add with addColumn](https://issues.apache.org/jira/browse/STORM-1963) HBase Put add() have deprecated , replace

[GitHub] storm pull request #1550: [STORM-1957] Support Storm JDBC batch insert

2016-07-11 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1550 [STORM-1957] Support Storm JDBC batch insert [STORM-1957 Support Storm JDBC batch insert](https://issues.apache.org/jira/browse/STORM-1957?jql=project%20%3D%20STORM) Batch insert

[GitHub] storm pull request #1462: [STORM-1883] FileReader extends Closeable Interfac...

2016-07-11 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1462#discussion_r70212495 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/FileReader.java --- @@ -20,10 +20,11 @@ import

[GitHub] storm pull request #1549: Fix Comment Error

2016-07-10 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1549 Fix Comment Error You can merge this pull request into a Git repository by running: $ git pull https://github.com/darionyaphet/storm fix-typos Alternatively you can review and apply

[GitHub] storm issue #1527: [STORM-1932] Change Duration's value data type

2016-07-04 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1527 @HeartSaVioR It seems fixed . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-06-27 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1527 [STORM-1932] Change Duration's value data type [STORM-1932](https://issues.apache.org/jira/browse/STORM-1932) BaseWindowedBolt Duration value is integer now . Use lo

[GitHub] storm pull request #1525: [STORM-1931] Share mapper and selector in Storm-Ka...

2016-06-27 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1525 [STORM-1931] Share mapper and selector in Storm-Kafka [STORM-1931](https://issues.apache.org/jira/browse/STORM-1931) Storm Kafka's mapper and selector and Storm Kafka trident

[GitHub] storm issue #1517: STORM-1919 Introduce FilterBolt on storm-redis

2016-06-27 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1517 @HeartSaVioR Thank you for you Great Work . I have a small question about `Mapper` extention structure . --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1517: STORM-1919 Introduce FilterBolt on storm-redis

2016-06-27 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1517#discussion_r68543199 --- Diff: external/storm-redis/README.md --- @@ -21,13 +21,16 @@ use it as a maven dependency: ### For normal Bolt -Storm-redis

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-26 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1501 @abhishekagarwal87 @HeartSaVioR `Storm-Kafka trident` `mappers` and `selectors` are very similar with `bolt`'s `mappers` and `selectors` . Maybe we can move them into one place ? -

[GitHub] storm pull request #1520: [STORM-1927] Upgrade Jetty and Ring

2016-06-26 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1520 [STORM-1927] Upgrade Jetty and Ring [STORM-1927](https://issues.apache.org/jira/browse/STORM-1927) Jetty 7 is EOL , upgrade to Jetty 9 & Ring could also support it. You can merge

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1515#discussion_r68347350 --- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -113,6 +113,15 @@ public StormTopology createTopology

[GitHub] storm pull request #1515: [STORM-1929] Check when create topology

2016-06-23 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1515 [STORM-1929] Check when create topology [STORM-1929](https://issues.apache.org/jira/browse/STORM-1929) Add some check when create topology : 1. Spout and Bolt id shouldn&#

[GitHub] storm issue #1455: [STORM-1872]Release Jedis connection when topology shutdo...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1455 @HeartSaVioR done ! travis ci started and working . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1509 @HeartSaVioR done ! travis ci started and working . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1509: [STORM-1921] Update parallelism_hint date type to integer

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1509 Hi @HeartSaVioR I should running `git rebase master` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1455: [STORM-1872]Release Jedis connection when topology...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1455#discussion_r68033224 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java --- @@ -34,4 +36,10

[GitHub] storm pull request #1509: [STORM-1921] Update parallelism_hint date type to ...

2016-06-22 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1509 [STORM-1921] Update parallelism_hint date type to integer [STORM-1921](https://issues.apache.org/jira/browse/STORM-1921) Update TopologyBuilder's parallelism_hint date type from N

[GitHub] storm issue #1508: STORM-1920 version of parent pom for storm-kafka-monitor ...

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1508 `versions-maven-plugin` is used when we want to manage the versions in a project's POM file . `Storm` have lot of modules this is maybe useful . --- If your project is set u

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-22 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1479 Sure . I will close it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1501 @HeartSaVioR I misunderstood what you meant. keep constructor with fieldName/fieldIndex and default topic name . thanks ~ --- If your project is set up for it, you can reply

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-22 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1501 I don't know why can't support `default topic` to collect the messages which not found topic name from tuple and keeping remove constructor . Now I have update to throw Exce

[GitHub] storm issue #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1479 filter bolt seems better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1501#discussion_r67977419 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + * Licensed

[GitHub] storm issue #1462: [STORM-1883] FileReader extends Closeable Interface

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1462 I think `FileReader` should same with 'java.io. FileReader' . Implement `Closeable` interface also have a better extension structure . --- If your project is set up for it, you ca

[GitHub] storm pull request #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1501#discussion_r67897721 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/selector/FieldNameTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + * Licensed

[GitHub] storm issue #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1479 @HeartSaVioR check `exists` is very useful . Sometimes we will check if a key is in a key set to decide if the value should be process . --- If your project is set up for it, you can reply

[GitHub] storm pull request #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-21 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR OK Close it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR Yes I know . Because Zookeeper properties is very useful , so I wish to open a new API to support it :) . If you think it's unnecessarily , I will close this PR . --- If

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-21 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR I got we can set config using `Config` and don't have to support new API ? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] storm pull request #1506: [STORM-1917] Storm Redis TTL Control

2016-06-20 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1506 [STORM-1917] Storm Redis TTL Control [STORM-1917](https://issues.apache.org/jira/browse/STORM-1917) Add a new interface to control key ttl . You can merge this pull request into a

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-20 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HariSekhon Yep So sorry ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-19 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HariSekhon what you mean is should remove `TODO` when all HBase options have provided ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-19 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1501 @HeartSaVioR thank you ~~ I have fix issues and add some comment at REAEMD to describe how to use `FieldNameTopicSelector` and `FieldIndexTopicSelector` --- If your project is set up for it

[GitHub] storm pull request #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-19 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1501#discussion_r67640174 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/selector/FieldIndexTopicSelector.java --- @@ -0,0 +1,52 @@ +/** + * Licensed

[GitHub] storm pull request #1501: [STORM-1914] Storm Kafka Field Topic Selector

2016-06-17 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1501 [STORM-1914] Storm Kafka Field Topic Selector [STORM-1914](https://issues.apache.org/jira/browse/STORM-1914) Support field name and field index to select which kafka topic will used as

[GitHub] storm pull request #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

2016-06-16 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1493 [STORM-1908] Support Storm HBase ZooKeeper Config [STORM-1908](https://issues.apache.org/jira/browse/STORM-1908) Support Storm HBase ZooKeeper Config . About ZooKeeper host , port and

[GitHub] storm pull request #1485: [STORM-1899] Release HBase connection when topolog...

2016-06-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1485#discussion_r67004722 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java --- @@ -73,4 +74,13 @@ public void prepare(Map map

[GitHub] storm pull request #1485: [STORM-1899] Release HBase connection when topolog...

2016-06-14 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1485 [STORM-1899] Release HBase connection when topology shutdown [STORM-1899](https://issues.apache.org/jira/browse/STORM-1899) Release HBase connection when topology shutdown You can

[GitHub] storm pull request #1483: STORM-1875 : Separate Jedis/JedisCluster Config

2016-06-11 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1483 STORM-1875 : Separate Jedis/JedisCluster Config [STORM-1875](https://issues.apache.org/jira/browse/STORM-1875) Separate Jedis / JedisCluster to provide full operations for each environment to

[GitHub] storm issue #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-10 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1479 @HeartSaVioR Yes I have realized that `RedisDataType` is a series of data format . But `EXISTS` is really heavily used in Redis usage . Should we split data and operation

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-10 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1479#discussion_r66598237 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/mapper/RedisDataTypeDescription.java --- @@ -23,7 +23,7

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-10 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1479#discussion_r66597076 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/mapper/RedisDataTypeDescription.java --- @@ -23,7 +23,7

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-10 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1479#discussion_r66596642 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/mapper/RedisDataTypeDescription.java --- @@ -23,7 +23,7

[GitHub] storm pull request #1479: [STORM-1880] Support EXISTS Command Storm-Redis

2016-06-10 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1479 [STORM-1880] Support EXISTS Command Storm-Redis [STORM-1880](https://issues.apache.org/jira/browse/STORM-1880) add exists command in storm-redis LookupBolt You can merge this pull

[GitHub] storm pull request #1478: [STORM-1896] HdfsSpout remove duplicated code

2016-06-09 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1478 [STORM-1896] HdfsSpout remove duplicated code [STORM-1896](https://issues.apache.org/jira/browse/STORM-1896) remove duplicated code in HdfsSpout open() You can merge this pull request

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks ~~ I have update commit message to JIRA title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks commit message same with JIRA title maybe better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
GitHub user darionyaphet reopened a pull request: https://github.com/apache/storm/pull/1477 [STORM-1895] Blob Store replication-factor argument [STORM-1895](https://issues.apache.org/jira/browse/STORM-1895) Storm command line argument --repl-fctr have update to replication

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR just a miss operation .. btw I couldn't reopen this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @abhishekagarwal87 Should I update commit message to `STORM-1895 : replace repl-fctr with replication-factor` ? --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1477 [STORM-1895] Blob Store replication-factor argument [STORM-1895](https://issues.apache.org/jira/browse/STORM-1895) Storm command line argument --repl-fctr have update to replication

[GitHub] storm pull request #1462: [STORM-1883] FileReader extends Closeable Interfac...

2016-06-05 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1462 [STORM-1883] FileReader extends Closeable Interface [STORM-1883](https://issues.apache.org/jira/browse/STORM-1883) use Closeable Interface to decorate FileReader to support close

[GitHub] storm pull request #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-05 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-05 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1459 OK , I will try to separating classes :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-05 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1459 `Storm-Redis` have support multiple keys operation ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-05 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1459 @HeartSaVioR Good ! I will try to split into two class . BTW Do you have any idea to unified `Jedis` and `JedisCluster` interface ? --- If your project is set up for it, you can reply to this

[GitHub] storm issue #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-05 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1459 @darionyaphet This is Jedis class diagram when Jedis was 2.5.0. At that time JedisCluster doesn't support multiple keys operation so now it becomes more complicated. https:

[GitHub] storm issue #1461: [STORM-1882] Expose TextFileReader public

2016-06-05 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1461 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1461: [STORM-1882] Expose TextFileReader public

2016-06-04 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1461 [STORM-1882] Expose TextFileReader public [STORM-1882](https://issues.apache.org/jira/browse/STORM-1882) TextFileReader is package-private .Should make TextFileReader a public class to

[GitHub] storm issue #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-04 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1459 Both `Jedis` and `JedisCluster ` have implemented `JedisCommands` interface . So I think we can use `JedisCommands` calling the same method on single redis instance and redis cluster

[GitHub] storm pull request #1459: [STORM-1875]Separate Jedis/JedisCluster Config

2016-06-02 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1459 [STORM-1875]Separate Jedis/JedisCluster Config [STORM-1875](https://issues.apache.org/jira/browse/STORM-1875) Separate Jedis / JedisCluster to provide full operations for each

[GitHub] storm pull request: STORM-1136: Command line module to return kafka spout of...

2016-05-31 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/1451 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm pull request: [STORM-1874]Update logger private permissions

2016-05-31 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1456 [STORM-1874]Update logger private permissions [STORM-1874](https://issues.apache.org/jira/browse/STORM-1874) Update Log access permissions from public to private . You can merge this

[GitHub] storm pull request: [STORM-1872]Release Jedis connection when topology shutd...

2016-05-31 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1455 [STORM-1872]Release Jedis connection when topology shutdown [STORM-1872](https://issues.apache.org/jira/browse/STORM-1872) Strom Redis connect should be release when topology

[GitHub] storm pull request: [Storm 1872] Storm Redis connection release

2016-05-31 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: [Storm 1872] Storm Redis connection release

2016-05-31 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1454 [Storm 1872] Storm Redis connection release Strom Redis connect should be release when topology shutdown . You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: STORM-1845: use UTF-8 instead of default encod...

2016-05-17 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/1422#issuecomment-219677080 Hi @vesense If I don't specified charset which one will be used ? --- If your project is set up for it, you can reply to this email and have your reply appe

  1   2   >