[GitHub] storm pull request #2492: Update TridentKafkaEmitter.java

2018-01-02 Thread dujiashu
GitHub user dujiashu opened a pull request: https://github.com/apache/storm/pull/2492 Update TridentKafkaEmitter.java fix fetchmessages offsetoutofrange bug. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dujiashu/storm master

[GitHub] storm issue #2492: Update TridentKafkaEmitter.java

2018-01-04 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 how can I pass the checkstyle? Thanks for help. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-04 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Thanks for you help. https://issues.apache.org/jira/browse/STORM-2883 ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-10 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 When tridentAPI, although set config.usestarttimeifoffsetoutofrange true, it would throw offsetoutofrange exception yet. This issue fix this bug. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-10 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Thanks so much. I always think opaquespout is only used to resolve kafka disk broken when not set replication ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-11 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Sure, this PR should be closed. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-14 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo OK. This my first use the github with make PR. I understatnd it now. ---

[GitHub] storm pull request #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-14 Thread dujiashu
Github user dujiashu closed the pull request at: https://github.com/apache/storm/pull/2492 ---