Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2475
1.1.x PR: #2521. It looks like #2320 is already in 1.1.x branch, thanks!
---
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2521
STORM-2862: More flexible logging in multilang
Connected to https://issues.apache.org/jira/browse/STORM-2862; 1.1.x
version of apache/storm#2475.
You can merge this pull request into a Git repository
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2475
@HeartSaVioR done.
If 1.1.2 is the next release then in an ideal world we'd get both this and
#2320 in there. Is that possible? I don't want to add to your workload so I'm
mor
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2475
@HeartSaVioR, I understand that the 1.2.0 and 1.1.2 releases might be
coming soon?
Do you know if 1.1.2 is going to be much before 1.2.0? If so, would it be
OK if I made a PR for the 1.1.x
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r162613466
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2475
@revans2, @HeartSaVioR, is this any better? Thanks.
---
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159972449
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159850662
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2475
Put contextual information in the ThreadContext for multilang logging.
Connected to https://issues.apache.org/jira/browse/STORM-2862; `master`
version of apache/storm#2474.
You can merge this pull
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2474
STORM-2862: More flexible logging in multilang
Connected to https://issues.apache.org/jira/browse/STORM-2862.
Put contextual information in the ThreadContext for multilang logging.
I&#x
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2320
Rebased & squashed.
---
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2323
Rebased & squashed.
---
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2320
`master` PR: https://github.com/apache/storm/pull/2323
When I was doing that, I noticed that the spacing in the log message had
already been fixed more nicely there, so
https://github.com
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2323#discussion_r138312797
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -17,6 +17,18 @@
*/
package org.apache.storm.blobstore
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2323
STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not update the blob
with key"
`master` version of https://github.com/apache/storm/pull/2320, connected to
https://issues.apache.org/j
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2320
Thanks! I'll work on a separate PR for master.
---
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2320
STORM-2736: fix o.a.s.b.BlobStoreUtils [ERROR] "Could not update the blob
with key"
Check for empty nimbus info list before attempting to update the blobstore.
You can merge this pull requ
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2281
STORM-2421: support lists of childopts in DaemonConfig.
1.1.x port of https://github.com/apache/storm/pull/2083 for
https://issues.apache.org/jira/browse/STORM-2421.
You can merge this pull request
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2083
https://github.com/apache/storm/pull/2112 makes most of the checkstyle
changes unnecessary, which is great! Rebased & squashed commits.
---
If your project is set up for it, you can reply to
Github user hmcc commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098567
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2083#discussion_r113902383
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -313,6 +315,34 @@ public static File getWorkerDirFromRoot(String
logRoot, String
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2083
STORM-2421: support lists of childopts in DaemonConfig.
Addresses https://issues.apache.org/jira/browse/STORM-2421 by:
- changing the annotation on DaemonConfig childopts to isStringOrStringList
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2029
@harshach Done :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2029#discussion_r110770061
--- Diff: examples/storm-elasticsearch-examples/pom.xml ---
@@ -53,6 +54,11 @@
storm-elasticsearch
${project.version
Github user hmcc closed the pull request at:
https://github.com/apache/storm/pull/1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user hmcc reopened a pull request:
https://github.com/apache/storm/pull/1984
STORM-2058: Fix Maven warnings about missing
reporting.plugins.plugin.version
Add versions for maven-javadoc-plugin and maven-surefire-report-plugin to
the parent pom.xml.
You can merge this pull
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/2029
STORM-2379: update for Elasticsearch 2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcc/storm STORM-2379
Alternatively you can review and
Github user hmcc closed the pull request at:
https://github.com/apache/storm/pull/1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user hmcc reopened a pull request:
https://github.com/apache/storm/pull/1984
STORM-2058: Fix Maven warnings about missing
reporting.plugins.plugin.version
Add versions for maven-javadoc-plugin and maven-surefire-report-plugin to
the parent pom.xml.
You can merge this pull
GitHub user hmcc opened a pull request:
https://github.com/apache/storm/pull/1984
STORM-2058: Fix Maven warnings about missing
reporting.plugins.plugin.version
Add versions for maven-javadoc-plugin and maven-surefire-report-plugin to
the parent pom.xml.
You can merge this pull
30 matches
Mail list logo
