Github user hummelm closed the pull request at:
https://github.com/apache/storm/pull/2591
---
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
@HeartSaVioR
Sorry what do you mean by reflect new review comments, is my last commit
[https://github.com/apache/storm/pull/2591/commits/229ccaf8ea4d73b7efe0e2d7d6d6d239af97950f](https
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
pull request for master branch:
[https://github.com/apache/storm/pull/2625](https://github.com/apache/storm/pull/2625)
---
GitHub user hummelm opened a pull request:
https://github.com/apache/storm/pull/2625
fix STORM-2979 (master branch)
Add in WorkerState an internal list of deserialized workerHooks and use it
to
start/stop
You can merge this pull request into a Git repository by running
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
for master branch do I have to create a new pull request ?
---
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
Here is a new implementation which is compatible with stateful workerhook.
I think this implementation is better isn't it ?
---
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
Yes i Will add a list of deserialized hook into the worker and use it to
start.stop.
---
Github user hummelm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2591#discussion_r178086243
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -566,9 +566,12 @@
worker-topology-context (worker-context worker
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
After some digging I finally found a workaround.
Using a simple trick in the start method of the worker-hook (rewind of
the byteBuffer to allow the deserialization on stop)it can work as
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
After some tests I can say that the issue also affects:
1.1.X
1.2.X
I'm pretty sure that master branch (2.X) is also affected but the worker
code have been rewritten in java.
GitHub user hummelm opened a pull request:
https://github.com/apache/storm/pull/2591
STORM-2979
The pom modification is only for test propose.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hummelm/storm 1.0.6-p1-fix-STORM-2979
11 matches
Mail list logo
