GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1675
Update
Update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alternatively you can review and apply these
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/1675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1677
STORM-1985: Admin Commands
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alternatively you can review and
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1677
Applied the review comments. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r80293802
--- Diff: bin/storm.py ---
@@ -572,6 +572,22 @@ def kill_workers(*args):
jvmtype="-client",
extrajars=[USE
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r80294599
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r80296458
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r81474369
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1677
@revans2 Thanks for reviewing the changes. Resolved the merge conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1814
STORM-1308
Please Review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alternatively you can review and apply
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1814
Thanks for reviewing the patch @HeartSaVioR .
Modified the pull request as per review comments. Please take a look.
My jira id is "kbhatt".
---
If your project is set up f
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1814
@HeartSaVioR Could you please review the revised pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1839
STORM-1292
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm storm_branch_1292
Alternatively you can review and apply
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1839
STORM-1292: port backtype.storm.messaging-test to java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/1839
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1882
STORM-1292: port backtype.storm.messaging-test to java View changes
This PR is in continuation of https://github.com/apache/storm/pull/1839.
I have applied all review comments in this
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1882
@harshach thanks for reviewing the PR. I tried to squash the commits but
not sure why it is throwing error.
---
If your project is set up for it, you can reply to this email and have your
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1882
@harshach I tried your suggestion "git rebase -i HEAD~9" and kept just one
comment and put s in front of all other comments. It gives error
Cannot 'squash' witho
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1882
@HeartSaVioR Applied your review comment. However not able to squash the
commits. Please help on this.
Once again thanks a lot for your help, always.
---
If your project is set up for it
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1948
Update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alternatively you can review and apply these changes as
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/1948
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1949
STORM-1290: port backtype.storm.local-state-test to java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1949#discussion_r102148450
--- Diff: storm-core/test/jvm/org/apache/storm/LocalStateTest.java ---
@@ -0,0 +1,54 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1949
@HeartSaVioR ,my apology for not responding to this early as some urgent
travel came up for me. Thanks for reviewing the PR. As you suggested I'll apply
the review comments and sub
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1949
My sincere apology for the delay on this. As you suggested I am closing
this PR and submit the revised one soon.
Thanks for all your help.
---
If your project is set up for it, you
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/2074
Storm 1290:port backtype.storm.local-state-test to java
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r111773697
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,43 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r112118064
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,43 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r112118639
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,43 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r112118745
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,43 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r112815175
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,43 @@
+package org.apache.storm;
+
+import
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2074
@harshach I tried multiple times but unable to squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/2074
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/2154
Storm 1290:port backtype.storm.local-state-test to java
These changes are in continuation of pull request
https://github.com/apache/storm/pull/2074
Please review.
You can merge
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2074
My Apology for the delay. Applied the review comments and created a new
pull request
https://github.com/apache/storm/pull/2154/files.
Please take a look.
---
If your project is
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2074
@srdo I was unable to squash the commits so created a new PR and applied
all required changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2074
@srdo Thanks for providing above steps. I applied these commands. It
updated the branch STORM-1290 but doesn't allow me to reopen this PR.
---
If your project is set up for it, you can
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2154
Modified as per review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/2233
Storm 2258: Streams api - support CoGroupByKey
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm STORM-2258
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2233
Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2233
Thanks for reviewing the PR. Modified the changes as per review comments.
Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r134122065
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the
Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r134122087
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2233
Unable to squash the commits, tried multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/2233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/2233
Thanks for all your help and guidance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/2296
Beam runner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/storm beam-runner
Alternatively you can review and apply these changes
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/2296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
49 matches
Mail list logo
