Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1710#discussion_r80798282
--- Diff:
storm-core/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java ---
@@ -159,10 +162,6 @@ public void set_worker_hb(String path, byte[] data
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1710
Addressed your comments. Not sure why they have not disappeared.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1710#discussion_r80508806
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClientHandler.java ---
@@ -69,7 +69,7 @@ else if(evm instanceof HBMessage
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user knusbaum reopened a pull request:
https://github.com/apache/storm/pull/1710
STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA
compatible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1710
STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA
compatible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78032590
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/IBlacklistStrategy.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78029793
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java
---
@@ -0,0 +1,142 @@
+/**
+ * Licensed
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78025692
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,212 @@
+package
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78024368
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,212 @@
+package
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78025095
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,212 @@
+package
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1674#discussion_r78023729
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,212 @@
+package
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
In addition to the ones @vesense noted, there are many other operators
without spaces around them. Adding space around `=`, `+`, `:`, `<`, etc, will
make the code more readable.
---
If y
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1676
Do we want this on any of the 1.* branches?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1676
STORM-2085: Remove guava from storm-core pom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2085-pick
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
@revans2 +1 for that. That's simpler to understand and implement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1674
We could just have some "relative badness" heuristic. I would expect the
supervisors would be in a bell curve of "goodness/badness" and we can just
blacklist the ones in the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1670
+1 pending SD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/838
@revans2 It looks like the HA/load balancing stuff didn't get pushed back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76169008
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,541 @@
*/
package
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1642
+1 on general direction. Readability is good; classes aren't too large or
convoluted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76162679
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,417 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76161402
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,417 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76160977
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,417 @@
+/**
+ * Licensed to the Apache Software
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/494
Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/534
Closing this. I like the idea, but this PR is very stale, and we're
translating to Java.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/478
I'm going to close this. Please feel free to reopen or create a new PR once
we have a style guide in place.
---
If your project is set up for it, you can reply to this email and have your
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/510
Closing this. Please reopen if it's still an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/471
Closing this. Reopen if it's still an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1645
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1591#discussion_r75354518
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -73,6 +73,20 @@
public static final String STORM_MESSAGING_NETTY_BUFFER_SIZE
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1627
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1627
+1 for the changes. My comments are suggestions for a couple more.
The travis failures look unrelated. Storm Core passes.
---
If your project is set up for it, you can reply to this email and
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1627#discussion_r74990425
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -316,7 +316,6 @@
:load-mapping (LoadMapping.)
:assignment
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1627#discussion_r74987767
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -743,7 +736,7 @@
(fn [&
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user knusbaum reopened a pull request:
https://github.com/apache/storm/pull/1620
STORM-1913: Additions and Improvements for Trident RAS API
This is just a backport of STORM-1913 (#1500) to the 1.x branch.
I'm not sure this actually needs a PR, but since it's be
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1621
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1619
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1620
STORM-1913: Additions and Improvements for Trident RAS API
This is just a backport of STORM-1913 (#1500) to the 1.x branch.
You can merge this pull request into a Git repository by running
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1592
@HeartSaVioR
Good to hear it. I don't know if we want to stop feature development on 1.x
since that's our release branch, and 2.x seems to have stalled. The policy
behind all
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1592
@HeartSaVioR
I'm +1 for the patch.
Nimbus has been in progress for porting for a long time. We can't
(apparently) halt all progress until it's ported. You recently sub
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1536
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1536#discussion_r70653301
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -18,7 +18,8 @@
(:use compojure.core)
(:use [clojure.java.shell :only [sh
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1536#discussion_r70648943
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -18,7 +18,8 @@
(:use compojure.core)
(:use [clojure.java.shell :only [sh
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1507
@d2r Sorry about missing that. Ready for a check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1547
STORM-1954: Large Trident topologies can cause memory issues due to
DefaultResourceDeclarer object reading config
You can merge this pull request into a Git repository by running:
$ git
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69977876
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -2092,6 +2092,11 @@ public static String addToClasspath(String classpath
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69816548
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1835,6 +1835,21 @@
public static final String TOPOLOGY_CLASSPATH
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69797890
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/workermanager/DefaultWorkerManager.java
---
@@ -347,14 +347,24 @@ protected String
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69788392
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1835,6 +1835,21 @@
public static final String TOPOLOGY_CLASSPATH
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69788000
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1835,6 +1835,21 @@
public static final String TOPOLOGY_CLASSPATH
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1500#discussion_r69755010
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java ---
@@ -56,7 +56,11 @@ public T setNumTasks(Number val
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1507
@HeartSaVioR @abhishekagarwal87 Would you guys give this another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1507
@HeartSaVioR @abhishekagarwal87
Yes, I accidentally included STORM-1913 in this PR. I'll remove it.
---
If your project is set up for it, you can reply to this email and have your
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1507
STORM-1916: Add ability for worker-first classpath
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-1916
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1500#discussion_r67725802
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java ---
@@ -56,7 +56,11 @@ public T setNumTasks(Number val
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1500
STORM-1913: Additions and Improvements for Trident RAS API
New behavior:
- Added a way to specify default values for operations in Trident
- New behavior requires all components in group
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1398#issuecomment-219518790
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1406#issuecomment-218289768
I think it's fine if this goes in. It doesn't add much to the metrics load,
and we already have a working solution for clusters whose zk instances get
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1397
STORM-1764: Pacemaker is throwing some stack traces
Pacemaker throws a handful of stack traces when the occasional weird thing
happens. This fixes an IndexOutOfBounds exception, a very strange
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1331#issuecomment-208469787
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1316#issuecomment-207676736
What do you mean?
If you mean null payloads are a special case, I disagree. In fact, it's not
a failure at all. We received a null message, so we can perf
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1308#issuecomment-207576774
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1316#issuecomment-207576535
Why not no both? I don't see any reason to propagate `TaskMessage`s with
null payloads, but I agree we should be dropping tuples that failed to
deserialize i
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1313#issuecomment-207576732
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1316#discussion_r58954552
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -431,13 +431,14 @@
(fn [tuple-batch sequence-id end-of-batch
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1285#issuecomment-204455105
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1290#discussion_r58224386
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/BlobStoreAclHandler.java ---
@@ -54,6 +54,7 @@
public static final List DEFAULT = new
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1292#issuecomment-204435577
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1291#issuecomment-204435446
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1262#issuecomment-204430280
+1
Nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1293
STORM-1673: log4j2/worker.xml refers old package of LoggerMetricsConsumer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1294
STORM-1673: log4j2/worker.xml refers old package of LoggerMetricsConsumer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1284#issuecomment-204229422
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1281#issuecomment-204227208
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-204225005
@ptgoetz +1 for quick merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1282#issuecomment-204221012
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-204220646
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1280#issuecomment-204220497
+1. Will merge tomorrow after 24hr period has passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1287#issuecomment-204207397
Please file a [Jira](http://issues.apache.org/jira/) for this and update
the title of the PR. I think it should be considered a bug, as this could
potentially be
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1262#discussion_r58153392
--- Diff:
examples/storm-starter/src/clj/org/apache/storm/starter/clj/bolts.clj ---
@@ -0,0 +1,78 @@
+;; Licensed to the Apache Software Foundation (ASF
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1262#issuecomment-204148932
Looks good for the most part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1262#discussion_r58132657
--- Diff:
examples/storm-starter/test/clj/org/apache/storm/starter/clj/bolts_test.clj ---
@@ -0,0 +1,115 @@
+;; Licensed to the Apache Software
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1262#discussion_r58131243
--- Diff:
examples/storm-starter/src/clj/org/apache/storm/starter/clj/bolts.clj ---
@@ -0,0 +1,75 @@
+;; Licensed to the Apache Software Foundation (ASF
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1286#issuecomment-204127745
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1273#issuecomment-204093716
@satishd @ptgoetz
Fine, but I think we need to stop putting stuff into 1.x real soon. This is
not a bug fix, it's an optimization. Continuing to add stuff t
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1276#issuecomment-203615052
+1 pending Travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1273#discussion_r57955514
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/WindowKryoSerializer.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1273#issuecomment-203612897
+1
Why does this need to go into 1.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1276#discussion_r57953984
--- Diff: storm-core/src/clj/org/apache/storm/testing4j.clj ---
@@ -79,10 +79,12 @@
[cluster-type mkClusterParam code]
`(let [supervisors# (or
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1277#discussion_r57951884
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -466,6 +466,21 @@
"assignedCpu" (.get_assi
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1276#issuecomment-203605221
Is there a reason for wanting this? I see you've made the change but no
code is using it.
---
If your project is set up for it, you can reply to this email and
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1279#issuecomment-203598725
Still +1 Pending SD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1279#issuecomment-203596039
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1277#discussion_r57948138
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -466,6 +466,21 @@
"assignedCpu" (.get_assi
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1256#issuecomment-202475739
Squashed and merged. Going in 1.x-branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
101 - 200 of 663 matches
Mail list logo
