Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-151831272
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-151841370
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-151358142
Updated the storm-kafka to list MessageMetadataSchemeAsMultiScheme as a
MultiScheme implementation. Let me know if there is anything else I should add.
---
If your
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-151139962
Will do. I will also update the CHANGELOG and contributors section of the
README.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-150749079
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-150746246
@HeartSaVioR No worries. I agree that the tupleMetaData flag is
superfluous. The instanceof check that is being done to guarantee type safety
can be used to determine
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-149210877
@HeartSaVioR Mind taking a look at these changes to determine if they
should be merged?
---
If your project is set up for it, you can reply to this email and have your
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-145277282
Conflicts resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-145112813
This branch has fallen a little behind since the changes have been made. I
will resolve the conflicts this evening.
---
If your project is set up for it, you can reply
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-102558140
Again apologies, I have never contributed code to an open source project
before. Clearly I did not understand the distinction between a contributor (me)
and a committer
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/550#issuecomment-101366953
STORM-697 is covered by https://github.com/apache/storm/pull/454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-101367295
I have never merged into storm before, reading on how to perform the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-101387750
Apologies, I have to register as an Apache committer before I can merge
these changes.
---
If your project is set up for it, you can reply to this email and have your
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-91916164
Good call, I will update TridentKafkaEmitter as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjtieman commented on the pull request:
https://github.com/apache/storm/pull/454#issuecomment-91930393
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user mjtieman opened a pull request:
https://github.com/apache/storm/pull/454
Storm 697: Support for Emitting Kafka Message Offset and Partition
It would be nice expose the offset and partition of messages consumed from
Kafka to the Scheme generating the Tuples
16 matches
Mail list logo