[GitHub] storm pull request #2036: [STORM-2440] Prevent KafkaSpout from hanging under...

2017-04-03 Thread nicom
Github user nicom commented on a diff in the pull request: https://github.com/apache/storm/pull/2036#discussion_r109373858 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -267,9 +267,11 @@ ((:report-error <>)

[GitHub] storm pull request #2036: [STORM-2440] Prevent KafkaSpout from hanging under...

2017-04-03 Thread nicom
GitHub user nicom reopened a pull request: https://github.com/apache/storm/pull/2036 [STORM-2440] Prevent KafkaSpout from hanging under certain Kafka failure scenarios Issue: https://issues.apache.org/jira/browse/STORM-2440 You can merge this pull request into a Git repository by

[GitHub] storm issue #2036: [DEV-2440] Prevent KafkaSpout from hanging under certain ...

2017-04-03 Thread nicom
Github user nicom commented on the issue: https://github.com/apache/storm/pull/2036 I just found out that this is a duplicate of #1932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2036: [DEV-2440] Prevent KafkaSpout from hanging under c...

2017-04-03 Thread nicom
Github user nicom closed the pull request at: https://github.com/apache/storm/pull/2036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2036: [DEV-2440] Prevent KafkaSpout from hanging under c...

2017-03-31 Thread nicom
GitHub user nicom opened a pull request: https://github.com/apache/storm/pull/2036 [DEV-2440] Prevent KafkaSpout from hanging under certain Kafka failure scenarios Issue: https://issues.apache.org/jira/browse/STORM-2440 You can merge this pull request into a Git repository by

[GitHub] storm issue #639: STORM-946: We should remove Closed Client form cached-node...

2016-06-16 Thread nicom
Github user nicom commented on the issue: https://github.com/apache/storm/pull/639 > may be fixed by STORM-1609 with the addition of the client keepalive TimerTask I can confirm that it is --- If your project is set up for it, you can reply to this email and have your re

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2016-03-31 Thread nicom
Github user nicom commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-203982738 @caofangkun Sorry for commenting on such an old pull request, but we recently also encountered the problem this patch is trying to address. > Does h