GitHub user pczb opened a pull request:
https://github.com/apache/storm/pull/1892
remove unused import in module kafkaclient
just remove some unused import and all tests passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pczb
Github user pczb commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r100485119
--- Diff: storm-core/src/jvm/org/apache/storm/metric/SystemBolt.java ---
@@ -85,14 +87,15 @@ public Object getValueAndReset
GitHub user pczb opened a pull request:
https://github.com/apache/storm/pull/2286
fix not poll bug when use manual commit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pczb/storm master
Alternatively you can review and apply
Github user pczb closed the pull request at:
https://github.com/apache/storm/pull/2286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2286
duplicate with #2156 closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user pczb opened a pull request:
https://github.com/apache/storm/pull/2661
[STORM-3055] remove conext connection cache
worker has already cache connection use supervisor_id + port
and if context and worker both cache the can be some problem describe in
jira
You can
GitHub user pczb opened a pull request:
https://github.com/apache/storm/pull/2669
[STORM-3055] remove conext connection cache
workerState has already cache connection use supervisor_id + port
and if context and worker both cache connection, there can be some problem
describe in
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@revans2 could you help review this, i see your pull request #2436 is
related to connection cache . and the travis fail is not related to this pr.
---
Github user pczb commented on a diff in the pull request:
https://github.com/apache/storm/pull/2669#discussion_r188355473
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -451,7 +451,6 @@ public int getPort() {
public void close
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@srdo add doc specification, i was wonder if we need remove synchronized
when bind port
@revans2 just as srdo says the connection will be closed by the worker
before worker shutdown.
i will
Github user pczb commented on a diff in the pull request:
https://github.com/apache/storm/pull/2669#discussion_r18812
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/IContext.java ---
@@ -38,6 +38,7 @@
/**
* This method establishes a server
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2669
@srdo @revans2 thanks for your review, i just squash all commit in one
---
Github user pczb commented on the issue:
https://github.com/apache/storm/pull/2661
port corresponding change #2669 to 1.1.x
---
13 matches
Mail list logo
