[GitHub] storm issue #2721: STORM-3110: Skip the user while checking isProcessAlive

2018-06-22 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2721 👍 ---

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-06-13 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Ping. ---

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-04 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Can you tell me how you tested your patch ? ---

[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port

2018-05-03 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @HeartSaVioR @ghajos Please review. ---

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-05-03 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2643 @HeartSaVioR Please look at this pull request https://github.com/apache/storm/pull/2660 ---

[GitHub] storm pull request #2660: STORM-3056: Add a test for quickly rebinding to a ...

2018-05-03 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/2660 STORM-3056: Add a test for quickly rebinding to a port Adding test as per discussion on https://github.com/apache/storm/pull/2643#issuecomment-385003933 You can merge this pull request into a

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-04-27 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2643 @ghajos We can bind to the port then close the port and then bind to the same port again. We have unit tests that can be used as a starting point. https://github.com/apache/storm/blob

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-04-27 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2643 Can you please add a test for this ? ---

[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state

2018-04-23 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2643 👍 ---

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

2017-02-02 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99237976 --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] storm pull request #1914: STORM-2334 - Join Bolt implementation with unit te...

2017-02-02 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1914#discussion_r99135627 --- Diff: storm-core/src/jvm/org/apache/storm/bolt/JoinBolt.java --- @@ -0,0 +1,428 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

2017-01-20 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97081027 --- Diff: storm-core/src/jvm/org/apache/storm/utils/TupleUtils.java --- @@ -40,7 +40,11 @@ public static boolean isTick(Tuple tuple

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

2017-01-20 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1889#discussion_r97081014 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,8 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm issue #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-19 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1866 👍 for reverting from 1.x & 1.0.x branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1889: STORM-2305: STORM-2279 calculates task index diffe...

2017-01-19 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1889 STORM-2305: STORM-2279 calculates task index different from grouper code @HeartSaVioR @arunmahadevan Please review. You can merge this pull request into a Git repository by running: $ git

[GitHub] storm issue #1850: STORM-2268 Disable integration test for Travis CI build

2017-01-18 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1850 @harshach I worked on this jira and found a few product issues. I worked with @HeartSaVioR and all these issues have been fixed & closed. The tests are running fine now. We only see

[GitHub] storm issue #1871: STORM-2268: Fix integration test for Travis CI build

2017-01-10 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1871 @HeartSaVioR Thanks for reviewing. I tried cherry picking commit to other branches and it was clean. Following runs are in progress for 1.x-branch & 1.0.x-branch: https://tr

[GitHub] storm pull request #1871: STORM-2268: Fix integration test for Travis CI bui...

2017-01-10 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1871 STORM-2268: Fix integration test for Travis CI build @HeartSaVioR Can you please review ? You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-10 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1866#discussion_r95460055 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -3600,7 +3600,7 @@ public ComponentPageInfo getComponentPageInfo(String

[GitHub] storm issue #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1866 @HeartSaVioR Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm pull request #1870: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1870 STORM-2279: Unable to open bolt page of storm ui I have added logic to wrap the negative indexes around effectively giving it a python like behaviour. Same as pull #1866 You can merge

[GitHub] storm pull request #1869: STORM-2279: Unable to open bolt page of storm ui

2017-01-09 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1869 STORM-2279: Unable to open bolt page of storm ui I have added logic to wrap the negative indexes around effectively giving it a python like behaviour. Same as pull #1866 You can merge

[GitHub] storm pull request #1866: STORM-2279: Unable to open bolt page of storm ui

2017-01-06 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1866 STORM-2279: Unable to open bolt page of storm ui I have added logic to wrap the negative indexes around effectively giving it a python like behaviour. You can merge this pull request into a

[GitHub] storm pull request #1857: STORM-2275: Nimbus crashed during state transition...

2017-01-04 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1857 STORM-2275: Nimbus crashed during state transition of topology You can merge this pull request into a Git repository by running: $ git pull https://github.com/raghavgautam/storm master

[GitHub] storm issue #1850: STORM-2268 Disable integration test for Travis CI build

2017-01-03 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1850 @HeartSaVioR I will take a look at why it is failing and fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1713: Storm 2124 show requested cpu mem for each component

2016-09-26 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1713 @HeartSaVioR I have started a conversation with travis-ci support, to see what we can do. I will update you on the progress. --- If your project is set up for it, you can reply to this email

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

2016-09-22 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1691 @ptgoetz Do we need to document any other place or just mentioning on the jira is sufficient ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

2016-09-22 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1691 I had mention this on the jira. A good part of the vagrant setup has been picked up from: https://github.com/ptgoetz/storm-vagrant https://github.com/harshach/storm-vagrant

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

2016-09-22 Thread raghavgautam
Github user raghavgautam closed the pull request at: https://github.com/apache/storm/pull/1691 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

2016-09-22 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1691 Thanks @harshach @HeartSaVioR for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

2016-09-21 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1691 @HeartSaVioR I have fixed the rat issue and I have put fast fail. Yes, we will be contributing more tests to apache storm going forward. --- If your project is set up for it, you can

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

2016-09-21 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79893753 --- Diff: integration-test/src/test/resources/storm-conf/storm.yaml --- @@ -0,0 +1,17 @@ + +storm.zookeeper.servers: +- "

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

2016-09-21 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79893438 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/window/TumblingTimeCorrectness.java --- @@ -0,0 +1,164

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

2016-09-19 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1691 STORM-2090: Add integration test for storm windowing You can merge this pull request into a Git repository by running: $ git pull https://github.com/raghavgautam/storm apache_master

[GitHub] storm issue #1636: [STORM-2047] Add note to add logviewer hosts to browser w...

2016-08-20 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1636 👍 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] storm pull request #1636: [STORM-2047] Add note to add logviewer hosts to br...

2016-08-19 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1636#discussion_r75531803 --- Diff: docs/SECURITY.md --- @@ -81,7 +81,9 @@ curl -i --negotiate -u:anyUser -b ~/cookiejar.txt -c ~/cookiejar.txt http://s 1. Firefox

[GitHub] storm pull request #1596: STORM-2008: kafka jars must be part of the storm-k...

2016-07-26 Thread raghavgautam
Github user raghavgautam closed the pull request at: https://github.com/apache/storm/pull/1596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1596: STORM-2008:

2016-07-26 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1596 STORM-2008: This is for solving following exception that we see when we try to run TridentKafkaWordCount topology. `` Exception in thread "main" java.lang.NoClassDef

[GitHub] storm pull request #1488: STORM-1906: Window count/length of zero should be ...

2016-06-15 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1488 STORM-1906: Window count/length of zero should be disallowed You can merge this pull request into a Git repository by running: $ git pull https://github.com/raghavgautam/storm master