[GitHub] storm pull request: STORM-1055

2015-09-20 Thread randerzander
GitHub user randerzander opened a pull request: https://github.com/apache/storm/pull/749 STORM-1055 missed a second map->hikariConfigMap. Please also merge in 0.10.x, which has the same README issue. You can merge this pull request into a Git repository by runn

[GitHub] storm pull request: STORM-1055

2015-09-20 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/storm/pull/748#issuecomment-141844499 Unfortunately I missed an additional map->hikariConfigMap example further down the README. Also, this applies to the 0.10.x branch as well. Is it possible to me

[GitHub] storm pull request: STORM-1055

2015-09-20 Thread randerzander
Github user randerzander commented on a diff in the pull request: https://github.com/apache/storm/pull/748#discussion_r39935407 --- Diff: external/storm-jdbc/README.md --- @@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes the core bolts and tri to

[GitHub] storm pull request: STORM-1055

2015-09-20 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/storm/pull/748#issuecomment-141827482 Not sure why the CI build failed, as I only modified the storm-jdbc README.. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-1055

2015-09-19 Thread randerzander
GitHub user randerzander opened a pull request: https://github.com/apache/storm/pull/748 STORM-1055 Fixed README by adding note about com.google.common.collect class usage, also fixed hikariConfigMap reference in example. You can merge this pull request into a Git repository by

[GitHub] storm pull request: Corrected ConnectionPrvoider to ConnectionProv...

2015-08-12 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/storm/pull/678#issuecomment-130415963 that's something you need to be comitter to do, right? I'm not sure how to use one PR to commit to multiple branches. --- If your project is set

[GitHub] storm pull request: Corrected ConnectionPrvoider to ConnectionProv...

2015-08-12 Thread randerzander
Github user randerzander commented on the pull request: https://github.com/apache/storm/pull/678#issuecomment-130236052 How do you want to handle the .10 update? Separate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: Corrected ConnectionPrvoider to ConnectionProv...

2015-08-11 Thread randerzander
GitHub user randerzander opened a pull request: https://github.com/apache/storm/pull/678 Corrected ConnectionPrvoider to ConnectionProvider You can merge this pull request into a Git repository by running: $ git pull https://github.com/randerzander/storm master Alternatively

[GitHub] storm pull request: corrected storm-hive README.md typos

2015-08-11 Thread randerzander
GitHub user randerzander opened a pull request: https://github.com/apache/storm/pull/676 corrected storm-hive README.md typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/randerzander/storm master Alternatively you can