Github user rban1 commented on the issue:
https://github.com/apache/storm/pull/2098
@harshach Can you please merge it if the changes look good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rban1 commented on the issue:
https://github.com/apache/storm/pull/2098
@harshach Thanks for the review. I have squashed commits into 1 and added a
section in the README
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2098#discussion_r114857665
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/FieldConstants.java
---
@@ -23,5 +23,6 @@
public static final String
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2098#discussion_r114857534
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/BinaryEventDataSystemPropertiesScheme.java
---
@@ -0,0 +1,51
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/2098
STORM-2499: Add Serialization plugin for EventHub System Properties
This PR adds a serialization scheme for eventhub systemproperties. There is
also a bug fix in an existing serialization scheme
Github user rban1 commented on the issue:
https://github.com/apache/storm/pull/2026
Made the necessary point changes and updated pom to use 0.13.1
@harshach I have changed the PR name appropriately. Also rebased and I
have only one commit in the commit history.
---
If your
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2026#discussion_r109327936
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/StringEventDataScheme.java
---
@@ -44,21 +38,32 @@
public class
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2026#discussion_r109327926
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventDataScheme.java
---
@@ -44,27 +41,31 @@
public class
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2026#discussion_r109327884
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/PartitionManager.java
---
@@ -41,29 +41,29 @@ public PartitionManager
Github user rban1 commented on the issue:
https://github.com/apache/storm/pull/2026
@SreeramGarlapati Made all the relavant changes(Serialization, exception
handling, enqueuetimefilter)
@harshach I will be using this PR going forward. I have addressed your
comments on syntax as
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2026#discussion_r108799438
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
---
@@ -65,77 +57,81 @@ public
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/2026
Eventhub3
Incorporating latest eventhub API changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rban1/storm eventhub3
Alternatively you can
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/1998
Eventhub2
latest changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rban1/storm eventhub2
Alternatively you can review and apply these
Github user rban1 closed the pull request at:
https://github.com/apache/storm/pull/1997
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/1997
Eventhub2
Latest eventhub changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rban1/storm eventhub2
Alternatively you can review and apply
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r104561334
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
---
@@ -65,77 +60,80 @@ public
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r104561293
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventDataScheme.java
---
@@ -46,25 +42,11 @@
private static final
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r10456
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/StringEventDataScheme.java
---
@@ -46,19 +39,11 @@
private static
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r104231241
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubReceiverImpl.java
---
@@ -65,77 +60,80 @@ public
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r104228014
--- Diff:
external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java
---
@@ -18,14 +18,16 @@
package
Github user rban1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1985#discussion_r104227737
--- Diff: external/storm-eventhubs/pom.xml ---
@@ -95,6 +95,11 @@
${eventhubs.client.version
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/1985
STORM-2371: New eventhub implementation
Made the changes with the latest comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rban1/storm
GitHub user rban1 opened a pull request:
https://github.com/apache/storm/pull/1951
STORM-2371 Implementing new eventhub driver
Changing the undelying receiver implementation with the latest Eventhub
receiver
You can merge this pull request into a Git repository by running
23 matches
Mail list logo
